You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
preserve the existing main.main-surface Codex root landmark
add scoped #root main support for Windows Codex 26.727.6591 (build 535)
record the live Windows verification metadata
Evidence
A privacy-safe codedrobe dom snapshot against the live build 535 renderer found one #root main, while aside.app-shell-left-panel and .composer-surface-chrome still matched. The released 0.6.1 and 0.7.0-beta.0 adapters both failed only adapter:root.
With this patch, the same real renderer probe changes from compatible: false to compatible: true, with rootMatches: ["#root main"].
Thanks for the suggestion. I checked the generic selectors against the live Windows Codex renderer that motivated this PR.
I kept main.main-surface as the preferred landmark and #root main as the fallback because both remain anchored to the application root. A bare main or [role="main"] is too broad for a blocking app fingerprint: Codex also uses route-level and auxiliary main regions, so those selectors can turn a partial/secondary surface into a false-compatible renderer.
I also considered [data-app-shell-main-surface] and [class*="_MainContentSurface_"], but they were not present in the verified Windows build 535 snapshot. I would prefer adding them after we have renderer evidence from a build that uses them rather than guessing at a hashed-class convention.
I pushed e32ec38 to document this boundary and added regression assertions that reject bare main / [role="main"] fallbacks.
Validation:
node --test tests/adapters.test.mjs: 13 passed
npm run typecheck: passed
Full npm test: 95 passed, 5 existing Windows path failures (for example G:\G:\code\... fixture resolution), unrelated to this adapter-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main.main-surfaceCodex root landmark#root mainsupport for Windows Codex 26.727.6591 (build 535)Evidence
A privacy-safe
codedrobe dom snapshotagainst the live build 535 renderer found one#root main, whileaside.app-shell-left-paneland.composer-surface-chromestill matched. The released 0.6.1 and 0.7.0-beta.0 adapters both failed onlyadapter:root.With this patch, the same real renderer probe changes from
compatible: falsetocompatible: true, withrootMatches: ["#root main"].Verification
node --test tests/adapters.test.mjs(13 passed)npm run typechecknpm run pack:check