London | 26 - JUL-SDC| Ping Wang |Sprint 5 |Spring 5 exercises-CYF 1155 - #647
Open
pathywang wants to merge 10 commits into
Open
London | 26 - JUL-SDC| Ping Wang |Sprint 5 |Spring 5 exercises-CYF 1155#647pathywang wants to merge 10 commits into
pathywang wants to merge 10 commits into
Conversation
pathywang
added
the
Needs Review
LonMcGregor
reviewed
Aug 12, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start on these tasks. There are some issues to work on.
Be careful of your spelling here, there are a few issues, can you resolve them?
Contributor
There was a problem hiding this comment.
Can you add explicit type annotations here?
| ] | ||
|
|
||
| for person in people: | ||
| possible_laptops = find_possible_laptops(laptops, person) |
Contributor
There was a problem hiding this comment.
When I run this, the suggested laptops are empty? Do you also see this?
| try: | ||
| preferred_os = OperatingSystem(os_input) | ||
| except ValueError: | ||
| print("Error: invalid operating system.", file=sys.stderr) |
Contributor
There was a problem hiding this comment.
Can you think of a more ux-friendly way of validating this input?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
did prep then make new directory and new branch for this coursework