fix(aws): use rolling ECS deployments - #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
With a desired count of one,
minimumHealthyPercent: 0andmaximumHealthyPercent: 100require ECS to stop the running task before it canstart the replacement. That creates an immediate Kite outage during every image
deployment.
Using
minimumHealthyPercent: 100andmaximumHealthyPercent: 200lets ECSstart and health-check the replacement before retiring the prior task. The
deployment circuit breaker and automatic rollback remain enabled.
Verification
pnpm check-typespnpm test(170 tests)(cd agent && uv run pytest)(72 tests)node node_modules/railway/dist/iac/bin.js(cd deployment/aws && pnpm build && pnpm test)(10 tests)kite-staging,kite-prod, andkite-communityremain healthy with one running task after applying the equivalent live ECS configuration