fix(tests): carry the runtime's required detail field in status mocks - #53
Open
jerelvelarde wants to merge 2 commits into
Open
fix(tests): carry the runtime's required detail field in status mocks#53jerelvelarde wants to merge 2 commits into
jerelvelarde wants to merge 2 commits into
Conversation
The 0.8.1 channels bump made status() return a required detail field. Four type errors in server.test.ts and one failing runtime-host assertion were left behind, so a fresh clone failed both check-types and test.
Collaborator
Author
|
Context for whoever picks this up:
Surfaced while verifying a review blocker on CopilotKit/website#467, which is making a clone of this repo the recommended fast path to a first Channel — so a red |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh clone of
mainfailspnpm check-types(exit 2, four errors) andpnpm test(161/162 passing). Both trace to thedetailfield@copilotkit/channels@0.8.1added tostatus(), which the bump in 356b6f6 did not carry into the test doubles.makeControlsis the source of all four type errors, so onedetail: {}clears them.app/runtime-host.test.ts:55then needed the real payload the runtime now returns.Verified on a clean
--depth 1clone: red before (check-typesexit 2,1 failed | 161 passed),check-typesexit 0 and 162/162 after.Kept
toEqualrather than relaxing totoMatchObject— its strictness about extra keys is what surfaced this drift, and it is worth keeping for the next one.Found while verifying a review blocker on CopilotKit/website#467, which recommends cloning this repo as the fast path to a first Channel.