Skip to content

fix: support SQL Server CREATE INDEX INCLUDE columns - #2462

Merged
manticore-projects merged 1 commit into
JSQLParser:masterfrom
jianjindream:codex/fix-2459-create-index-include
Aug 13, 2026
Merged

fix: support SQL Server CREATE INDEX INCLUDE columns#2462
manticore-projects merged 1 commit into
JSQLParser:masterfrom
jianjindream:codex/fix-2459-create-index-include

Conversation

@jianjindream

Copy link
Copy Markdown
Contributor

What changed

Added support for SQL Server CREATE INDEX ... INCLUDE (...) clauses.

CreateIndex() now consumes the INCLUDE column list directly after the index key columns and preserves the clause through the existing create-index tail parameters.

Why

K_INCLUDE was already tokenized, but the create-index grammar did not accept it after the index key columns. As a result, statements such as:

CREATE INDEX idx_a ON t1 (a) INCLUDE (b, c)

failed with a ParseException at K_INCLUDE.

Tests

  • Added a regression test covering parsing and deparsing of CREATE INDEX ... INCLUDE (b, c).
  • Verified that the regression test fails before the grammar change and passes afterward.
  • Ran:
./gradlew.bat test --tests net.sf.jsqlparser.statement.create.CreateIndexTest
./gradlew.bat spotlessApply

Fixes #2459

@jianjindream
jianjindream marked this pull request as ready for review August 13, 2026 05:15
Copilot AI lite review requested due to automatic review settings August 13, 2026 05:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the CREATE INDEX grammar to accept SQL Server-style INCLUDE (...) non-key columns immediately after the index key column list, and ensures the clause is preserved through the existing “tail parameters” mechanism so it round-trips via toString() and the deparser.

Changes:

  • Updated CreateIndex() grammar to optionally parse INCLUDE (col, ...) after the index key columns and store it in tailParameters.
  • Added a regression test for parsing + deparsing CREATE INDEX ... INCLUDE (b, c) (Issue #2459).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt Accepts INCLUDE (...) after index key columns and preserves it via tailParameters.
src/test/java/net/sf/jsqlparser/statement/create/CreateIndexTest.java Adds a regression test covering parse/deparse round-trip for INCLUDE columns.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@manticore-projects
manticore-projects merged commit b5adb60 into JSQLParser:master Aug 13, 2026
7 checks passed
@manticore-projects

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] JSQLParser Version 5.4-SNAPSHOT : MS SQL Server: CREATE INDEX ... INCLUDE ... not support

3 participants