fix: support SQL Server CREATE INDEX INCLUDE columns - #2462
Merged
manticore-projects merged 1 commit intoAug 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the CREATE INDEX grammar to accept SQL Server-style INCLUDE (...) non-key columns immediately after the index key column list, and ensures the clause is preserved through the existing “tail parameters” mechanism so it round-trips via toString() and the deparser.
Changes:
- Updated
CreateIndex()grammar to optionally parseINCLUDE (col, ...)after the index key columns and store it intailParameters. - Added a regression test for parsing + deparsing
CREATE INDEX ... INCLUDE (b, c)(Issue #2459).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt |
Accepts INCLUDE (...) after index key columns and preserves it via tailParameters. |
src/test/java/net/sf/jsqlparser/statement/create/CreateIndexTest.java |
Adds a regression test covering parse/deparse round-trip for INCLUDE columns. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added support for SQL Server
CREATE INDEX ... INCLUDE (...)clauses.CreateIndex()now consumes theINCLUDEcolumn list directly after the index key columns and preserves the clause through the existing create-index tail parameters.Why
K_INCLUDEwas already tokenized, but the create-index grammar did not accept it after the index key columns. As a result, statements such as:failed with a
ParseExceptionatK_INCLUDE.Tests
CREATE INDEX ... INCLUDE (b, c).Fixes #2459