Skip to content

feat(server): advisor_gate stats projection and e2e coverage - #383

Open
eric-liu-nvidia wants to merge 2 commits into
claude/advisor-gate-2-routefrom
claude/advisor-gate-3-telemetry
Open

feat(server): advisor_gate stats projection and e2e coverage#383
eric-liu-nvidia wants to merge 2 commits into
claude/advisor-gate-2-routefrom
claude/advisor-gate-3-telemetry

Conversation

@eric-liu-nvidia

Copy link
Copy Markdown
Contributor

Stack 3/3 — builds on #382 (server route). Review only this PR's diff; it targets #382's branch.

Telemetry and end-to-end coverage for the advisor gate:

  • /v1/stats gains an algorithm_stats.advisor_gate block (reviews by verdict and trigger, consult failures by reason, REDO-discarded turns and their tokens), following the feat(server): expose stage router stats #344 stage-router projection pattern with reset baselines.
  • 6 server e2e tests: approve flow + stats buckets, REDO call order and body shape, proxy_x_session_id-scoped budgets, verbatim SSE replay of provider events, fail-open on advisor outage, routing-log tier, count_tokens via the executor, and stats reset.

Stack: #371 (core algorithm) → #382 (server route) → this PR.

🤖 Generated with Claude Code

@eric-liu-nvidia
eric-liu-nvidia requested a review from a team as a code owner August 12, 2026 17:18
@eric-liu-nvidia
eric-liu-nvidia force-pushed the claude/advisor-gate-3-telemetry branch 2 times, most recently from 329229f to dd6f239 Compare August 12, 2026 18:27
@eric-liu-nvidia
eric-liu-nvidia force-pushed the claude/advisor-gate-2-route branch 2 times, most recently from dcba2ee to 010209f Compare August 12, 2026 21:50
@eric-liu-nvidia
eric-liu-nvidia force-pushed the claude/advisor-gate-3-telemetry branch from dd6f239 to 94ea1d1 Compare August 12, 2026 21:50
Signed-off-by: zengyuanl <zengyuanl@nvidia.com>
Signed-off-by: zengyuanl <zengyuanl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant