fix(cuda.core): explicit exception chaining in GB_callback cleanup path - #2610
Open
mdboom wants to merge 1 commit into
Open
fix(cuda.core): explicit exception chaining in GB_callback cleanup path#2610mdboom wants to merge 1 commit into
mdboom wants to merge 1 commit into
Conversation
When _capture_tail_node fails, the anonymous-commit cleanup calls HANDLE_RETURN inside the except handler. If that HANDLE_RETURN also raises, Python's implicit chaining would emit a confusing "During handling of the above exception, another exception occurred" message that buries the real CUDA error. Make the causal relationship explicit with `raise commit_exc from orig_exc`. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
mdboom
added
bug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GB_callback, when_capture_tail_nodefails the handler callsgraph_commit_attachmentandHANDLE_RETURNas anonymous-owner cleanup. If thatHANDLE_RETURNraises, Python implicitly sets__context__to the caught exception, producing a confusing "During handling of the above exception, another exception occurred" traceback that buries the real CUDA error.except:toexcept BaseException as orig_exc:and wrapped the cleanupHANDLE_RETURNin atry/exceptthat usesraise commit_exc from orig_excto make the causal relationship explicit.Test plan
pytest cuda_core/tests/) cover the_capture_tail_nodepath including_capture_callback_with_tail_failure_for_testing🤖 Generated with Claude Code