fix: Remove unnecessary shell quoting from GITHUB_ENV write

[andrewwhitecdw]

This PR addresses the following issue in .github/workflows/test-wheel-windows.yml: Remove unnecessary shell quoting from GITHUB_ENV write.

Changes

• .github/workflows/test-wheel-windows.yml: Remove unnecessary shell quoting from GITHUB_ENV write.

Details

--- a/.github/workflows/test-wheel-windows.yml
+++ b/.github/workflows/test-wheel-windows.yml
@@ -1,1 +1,1 @@
-        run: echo "PYTEST_ADDOPTS=\"--count=${{ inputs.nruns }}\"" >> "$GITHUB_ENV"
+        run: echo "PYTEST_ADDOPTS=--count=${{ inputs.nruns }}" >> "$GITHUB_ENV"

Tests

• cuda_core/tests/test_ci_env.py

--- /dev/null
+++ b/cuda_core/tests/test_ci_env.py
@@ -0,0 +1,18 @@
+import os
+import shlex
+
+
+def test_pytest_addopts_no_literal_quotes():
+    """Ensure PYTEST_ADDOPTS, if set by CI, does not contain literal quotes.
+
+    GitHub Actions env-file values are taken literally after the '=', so
+    escaped quotes written to $GITHUB_ENV become part of the value.  This
+    test guards against that regression.
+    """
+    opts = os.environ.get("PYTEST_ADDOPTS", "")
+    if not opts:
+        return
+    assert not (opts.startswith('"') and opts.endswith('"')), (
+        f"PYTEST_ADDOPTS contains literal quotes: {opts!r}"
+    )
+    # Ensure pytest can still parse the value.
+    shlex.split(opts)

Contributor guidelines

Per this repo's CONTRIBUTING.md:

• All commits are signed off (Signed-off-by trailer, DCO).

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[mdboom]

To be honest, I don't mind it as-is, even though it's unnecessary. If we change that to a more complex expression that does need the quoting we are less likely to have an issue. I'm going to close this one.