Speed up parseMod by pre-filtering patterns - #10216
Draft
vaisest wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This is an idea PR of a way to speed up
parseMod()a lot. This brings the time to generate a modcache containing the item db mods, and all item modsdata.itemModsfrom around 18 sec to around 2 sec for the first working version of this. It's definitely possible to be many times faster.This is more of a solution looking for a problem and was mostly done out of curiosity
I think this is somewhat similar to e.g. what the Rust regex crate or Intel hyperscan etc do. The idea is to:
The used aho-corasick implementation was https://gist.github.com/Validark/d493cfd1b3425c2e3073f5ccd08fbeb9, which is the first pure lua implementation I found. I have zero clue if it's slow or not.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: