fix crash when a custom mod has an invalid support gem in it - #10218
Open
Trifall wants to merge 1 commit into
Open
fix crash when a custom mod has an invalid support gem in it#10218Trifall wants to merge 1 commit into
Trifall wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10209
Description of the problem being solved:
While entering 'Skills socketed in your gloves are supported by level 20 Arcane Surge' as a custom modifier, the intermediate text ending in 'Arc' was parsed as the Arc active skill. CalcSetup then attempted to resolve a non-existent 'SupportArc' granted effect and crashed when it tried to mark the missing effect as item-granted.
Extra supports now resolve a matching support effect before it is marked as item-granted. Invalid partial skill names are ignored, while valid support names and same-name collisions such as Barrage continue to resolve correctly.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: