update mana efficiency mod on Militant Faith trade search - #10219
Open
Trifall wants to merge 2 commits into
Open
update mana efficiency mod on Militant Faith trade search#10219Trifall wants to merge 2 commits into
Trifall wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10191
Description of the problem being solved:
The Militant Faith 'Skill Cost' devotion modifier was generating trade searches for the legacy '#% reduced Mana Cost of Skills per 10 Devotion' modifier. Jewels dropped from 3.29 onward instead have '#% increased Mana Cost Efficiency per 10 Devotion'.
The trade modifier mapping now uses the current Mana Cost Efficiency trade stat. Legacy Militant Faith jewels remain supported in existing builds.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A
Before screenshot:
After screenshot: