You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix path buffer leaks in the DFS v2 utimensat() implementation.
Root cause
link_fn was allocated before validating the path and before several early returns, so those error paths leaked the buffer. In addition, the path returned by dfs_dentry_full_path() for a relative path was not retained separately and was never released; it could also be overwritten while resolving a symbolic link.
Changes
Allocate the symbolic-link buffer only when a link must be followed.
Keep ownership of the dynamically generated relative path in a separate pointer.
Route post-allocation error paths through common cleanup.
Return an allocation error when the symbolic-link buffer cannot be allocated.
Impact
Prevents heap growth from failed or repeated utimensat() calls while preserving the existing path and timestamp handling behavior.
Validation
git diff --check
Built bsp/qemu-vexpress-a9 successfully with scons -j4; this configuration compiles DFS v2 and the modified dfs_posix.c.
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!
为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).
设置需排除的文件/目录（目录请以"/"结尾）
Set files/directories to exclude (directories should end with "/")
将目标分支设置为 \ Set the target branch to：agent/fix-utimensat-path-leaks
设置PR number为 \ Set the PR number to：11700
等待工作流完成 | Wait for the workflow to complete
格式化后的代码将自动推送至你的分支。
The formatted code will be automatically pushed to your branch.
完成后，提交将自动更新至 agent/fix-utimensat-path-leaks 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the agent/fix-utimensat-path-leaks branch automatically, and the related Pull Request will be updated.
如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix path buffer leaks in the DFS v2
utimensat()implementation.Root cause
link_fnwas allocated before validating the path and before several early returns, so those error paths leaked the buffer. In addition, the path returned bydfs_dentry_full_path()for a relative path was not retained separately and was never released; it could also be overwritten while resolving a symbolic link.Changes
Impact
Prevents heap growth from failed or repeated
utimensat()calls while preserving the existing path and timestamp handling behavior.Validation
git diff --checkbsp/qemu-vexpress-a9successfully withscons -j4; this configuration compiles DFS v2 and the modifieddfs_posix.c.Fixes #11605