4.x: Streamable.timer to dispose the executor/scheduler upon finish - #8286
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.586 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8286 +/- ##
=========================================
Coverage 98.60% 98.61%
+ Complexity 7148 7147 -1
=========================================
Files 824 824
Lines 50789 50791 +2
Branches 6910 6911 +1
=========================================
+ Hits 50080 50086 +6
- Misses 477 481 +4
+ Partials 232 224 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot to cleanup the resource (Scheduler.Worker, Future) upon
finishexecuting. Just setting it toDISPOSEDcan lead to worker leak or task occupying the executor until their timer runs out.Trivial fix.
Testing it, however, needed a
TestSchedulerupdate:Reported as ??? security vulnerability ??? via AI tool and zero human understanding
@August829
RxJava-11: StreamableTimer.finish() Bypasses DisposableHelper.dispose(), Leaving the Real Scheduled Task/Thread Running
🛑 Do not report memory or resource leaks as security vulnerabilities 🛑
These are ordinary oversights or corner case bugs, in an alpha library, that goes up to maven central so that the brave can look at it, and allows me to use it in other companion libraries already.
I've updated the
SECURITY.mdto emphasize it again; do not report leaks as security vulnerabilities. Post an issue or PR.Resolves #8285