build: update bazel dependencies (22.1.x) - #33854
Conversation
See associated pull request for more information.
There was a problem hiding this comment.
Code Review
This pull request updates several Bazel dependencies in MODULE.bazel, including aspect_rules_js, aspect_rules_ts, rules_pkg, and aspect_rules_esbuild, along with their corresponding lockfile updates in MODULE.bazel.lock. The review feedback correctly points out that upgrading aspect_rules_ts to 3.10.0 deprecates the ext module extension, and provides a helpful code suggestion to transition to the new typescript extension API.
| bazel_dep(name = "aspect_rules_ts", version = "3.9.2") | ||
| bazel_dep(name = "rules_pkg", version = "1.2.0") | ||
| bazel_dep(name = "aspect_rules_js", version = "3.4.0") | ||
| bazel_dep(name = "aspect_rules_ts", version = "3.10.0") |
There was a problem hiding this comment.
With the upgrade of aspect_rules_ts to 3.10.0, the ext module extension has been deprecated in favor of the new typescript extension API.\n\nPlease update the usage of ext in this file (lines 187-194) to use the new typescript extension instead. For example:\n\nstarlark\ntypescript = use_extension(\"@aspect_rules_ts//ts:extensions.bzl\", \"typescript\")\ntypescript.deps(\n name = \"angular_cli_npm_typescript\",\n ts_integrity = \"sha512-y2TvuxSZPDyQakkFRPZHKFm+KKVqIisdg9/CZwm9ftvKXLP8NRWj38/ODjNbr43SsoXqNuAisEf1GdCxqWcdBw==\",\n ts_version = \"6.0.3\",\n)\nuse_repo(typescript, **{\"npm_typescript\": \"angular_cli_npm_typescript\"})\n
This PR contains the following updates:
0.26.0→0.27.03.3.1→3.4.03.9.2→3.10.01.2.0→1.3.0Release Notes
aspect-build/rules_ts (aspect_rules_ts)
v3.10.0Using Bzlmod:
Add to your
MODULE.bazelfile:What's Changed
typescriptbzlmod extension API, deprecateextby @jbedard in #975Full Changelog: aspect-build/rules_ts@v3.9.2...v3.10.0