fix(material/button): compute M2 icon-button density padding with CSS calc - #33657
Open
jvanderen1 wants to merge 4 commits into
Open
fix(material/button): compute M2 icon-button density padding with CSS calc#33657jvanderen1 wants to merge 4 commits into
jvanderen1 wants to merge 4 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I went ahead and signed the CLA, but don't know how to re-trigger the check. |
crisbeto
approved these changes
Aug 10, 2026
jvanderen1
force-pushed
the
fix/icon-button-dynamic-padding-calc
branch
from
August 11, 2026 15:11
98bafb7 to
d1e2d8a
Compare
jvanderen1
force-pushed
the
fix/icon-button-dynamic-padding-calc
branch
from
August 11, 2026 15:13
d1e2d8a to
1fafde2
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
…e calc Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
math.divpadding in the M2 icon-button density theme with native CSScalc()using--mat-icon-button-state-layer-sizeand--mat-icon-button-icon-size.icon-button.scss.sass:math/$icon-sizehelpers from the density path.Test plan
0through-5keep the icon visually centered--mat-icon-button-state-layer-sizeand confirm padding updates with width/height--mat-icon-button-icon-sizeand confirm padding updates accordingly