fix(subscription): avoid per-provider poll backoff - #18448
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
jt2594838
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
The subscription consumer round-robins all available DataNode providers. After any provider returned an empty poll response, it slept for 50-150 ms before trying the next provider. In a multi-DataNode deployment where only some providers own active subscription queues, these per-provider sleeps made consumption time grow with the provider count even when another provider already had data ready.
Fix
Track the number of currently available providers in each serial poll round. An empty response now immediately advances to the next provider, and the existing random backoff runs only after a complete round returns no user message. Provider RPCs remain serial, and single-provider behavior is unchanged.
Tests
Added unit coverage for:
Verified with:
mvn spotless:apply -pl iotdb-client/subscriptionmvn -Ddevelocity.off=true test -pl iotdb-client/subscription(50 tests)mvn -Ddevelocity.off=true -DskipTests test-compile -pl iotdb-client/subscription -P with-zh-localeThis PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
AbstractSubscriptionConsumerAbstractSubscriptionProvidersSubscriptionConsumerMultiProviderPollTest