Skip to content

[Subscription] Reduce consensus commit warning log noise - #18450

Open
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/reduce-consensus-subscription-commit-log-noise
Open

[Subscription] Reduce consensus commit warning log noise#18450
Caideyipi wants to merge 1 commit into
apache:masterfrom
Caideyipi:fix/reduce-consensus-subscription-commit-log-noise

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Reduce warning-log amplification when consensus subscription commit requests contain many rejected contexts.

  • Keep the receiver-level partial-commit summary at WARN.
  • Log rejected normal ACK context details at DEBUG while retaining WARN for internal NACK failures.
  • Log missing outstanding commit mappings at DEBUG because late or duplicate ACKs are already reported by the queue or summarized by the receiver.

In the reported 1,000-table / 100,000-device workload, this reduces a typical commit from about 114 WARN lines to one summary WARN while preserving detailed diagnostics at DEBUG.

Validation

  • mvn spotless:check -pl iotdb-core/datanode
  • mvn checkstyle:check -pl iotdb-core/datanode -DskipTests (0 violations)
  • ConsensusSubscriptionCommitStateTest passed 9/9 on the 2.0.11 implementation branch.
  • The same targeted test on current master was blocked during compilation by unrelated stale SNAPSHOT cross-module errors in existing Pipe, Schema, and RPC sources; the test phase was not reached.

This PR has:

  • been self-reviewed.
  • added comments explaining the why and intent where it is not obvious.

Key changed classes
  • ConsensusSubscriptionBroker
  • ConsensusSubscriptionCommitManager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant