[Subscription] Disable subscription by default - #18457
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable subscription by default and expose
subscription_enabled=falsein the system configuration template.When subscription is disabled, its query-memory proportion is forced to zero, so the configured subscription share remains available to the other query-engine components. Subscription integration tests now enable the feature explicitly.
Tests
mvn spotless:check -pl iotdb-core/node-commons,iotdb-core/datanode -Dcheckstyle.skip=truemvn spotless:check -pl integration-test -Pwith-integration-tests -Dcheckstyle.skip=truemvn -pl iotdb-core/node-commons -Dtest=CommonConfigTest -DfailIfNoTests=false -Drat.skip=true -Dcheckstyle.skip=true -DforkCount=0 testDataNodeMemoryConfigTestvia isolated JUnit execution: 12 tests passedThe regular DataNode Maven test command is currently blocked by unrelated generated-source and local snapshot mismatches, including missing
Accumulator,IFill, and a stale ConfigNode Thrift interface.This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
CommonConfigDataNodeMemoryConfig