Skip to content

[to dev/1.3] Improve query modification loading memory control (#17788) - #18466

Open
shuwenwei wants to merge 3 commits into
dev/1.3from
loadModificationFileWithMemControl-1.3
Open

[to dev/1.3] Improve query modification loading memory control (#17788)#18466
shuwenwei wants to merge 3 commits into
dev/1.3from
loadModificationFileWithMemControl-1.3

Conversation

@shuwenwei

Copy link
Copy Markdown
Member

Cherry-pick d563cd0 (#17788) to dev/1.3.

Adapted to 1.3 APIs:

  • Modification / Iterator
  • PlainDeviceID
  • PartialPath(IDeviceID, String) checked exception handling

@shuwenwei
shuwenwei marked this pull request as draft August 13, 2026 09:41
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.14286% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.51%. Comparing base (fb0b2d9) to head (c6b52c3).
⚠️ Report is 2 commits behind head on dev/1.3.

Files with missing lines Patch % Lines
...ne/execution/fragment/FragmentInstanceContext.java 17.39% 19 Missing ⚠️
...modification/io/LocalTextModificationAccessor.java 79.06% 9 Missing ⚠️
...ne/execution/fragment/QueryModificationLoader.java 95.27% 6 Missing ⚠️
.../planner/memory/FakedMemoryReservationManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev/1.3   #18466      +/-   ##
=============================================
+ Coverage      44.46%   44.51%   +0.04%     
  Complexity       198      198              
=============================================
  Files           3641     3643       +2     
  Lines         246603   246813     +210     
  Branches       30284    30316      +32     
=============================================
+ Hits          109654   109860     +206     
- Misses        136949   136953       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shuwenwei
shuwenwei marked this pull request as ready for review August 13, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant