support streamnode - #18470
Open
suchenglong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Content1: Refactor - refactor metric framework to support additional prefixes
In
MetricConfigDescriptor, the node-type property prefixes"cn_"and"dn_"were previously inlined as stringliterals in three call sites: the two
boolean isConfigNodeoverloads ofloadProps/loadHotProps(which forward tothe
String prefixoverloads via a ternary), and theif (prefix.equals(...))guard insidegenerateFromPropertiesthat limits the internal-reporter config to DataNode.
These literals are now declared as two
private static final Stringconstants near the top of the class:The three use sites now reference the constants instead of the literals. No other strings in the file (property keys
such as
metric_reporter_list, default values, comments mentioning"cn_"/"dn_"/"sn_"in javadoc) were touched,per the scope of the change.
This PR has: