fix(tests): use portable bigint test literals - #200
Open
ChaomingZhangCN wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A
On macOS arm64,
longandint64_tare distinct C++ types. As a result, expressions such asLiteral(5l)instantiateLiteral<long>, whileLiteralonly explicitly instantiates its constructor forint64_t. This causes the Parquet test executable to fail during linking:This change replaces the plain
longliterals used by Parquet BIGINT predicate tests with an explicitint64_thelper. It follows the existing approach used by the corresponding ORC predicate tests.Both predicate conversion and predicate pushdown tests are updated so that the complete
paimon-parquet-format-testtarget can link successfully on macOS arm64.Tests
Verified on macOS arm64:
cmake --build build --target paimon-parquet-format-test -j 8 ./build/debug/paimon-parquet-format-test \ --gtest_filter='PredicateConverterTest.*' git diff --check HEAD^ HEADResults:
paimon-parquet-format-testcompiled and linked successfully.PredicateConverterTest.*: 7 tests passed.git diff --check: passed.The complete Parquet test binary was also started locally. Some existing Parquet I/O tests fail during Arrow JSON test-data setup with
std::bad_castor an Arrow assertion. Those failures occur outside the code changed by this patch.API and Format
No public API, storage format, or protocol changes.
Documentation
No documentation changes. This patch only improves test portability.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)