feat!: remove the discover command and Discover API integration - #25
Open
nirsha-brd wants to merge 1 commit into
Open
feat!: remove the discover command and Discover API integration#25nirsha-brd wants to merge 1 commit into
nirsha-brd wants to merge 1 commit into
Conversation
Removes `brightdata discover` / `bdata discover` and its integration with the Bright Data Discover API (POST/GET https://api.brightdata.com/discover). Deletes the command, its types and its test file, deregisters it from the program in src/index.ts, drops the `discover` case from the --help Examples coverage test, and removes the command from the README command table, table of contents and reference section. BREAKING CHANGE: the `discover` command is no longer available.
nirsha-brd
marked this pull request as ready for review
August 12, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
brightdata discover/bdata discoverand its integration with the Bright Data Discover API (POST/GET https://api.brightdata.com/discover).This is the inverse of #3, which added the command.
Changes
src/commands/discover.tssrc/types/discover.tssrc/__tests__/commands/discover.test.tssrc/index.tsprogram.addCommand(discover_command)registrationsrc/__tests__/utils/help.test.tsdiscovercase from the "every customer-facing command has Examples in --help" coverage tableREADME.md### discoverreference sectionpackage.jsonsrc/__tests__/utils/help.test.tsis worth a look in review — it was added after #3, so it is not in that PR's file list, but it importsdiscover_commandand would fail to compile without this change.Verification
pnpm run type-check— clean, exit 0pnpm run build(tsc) — clean, exit 0pnpm test— no new failures. This suite is already red onmainin a Windows environment; I captured a baseline before making any change and the failing set is byte-for-byte identical:main)The deltas are exactly the removed
discover.test.ts(1 file, 16 tests). The same 8 tests fail before and after, all inbrowser/ipc,browser/lifecycle,commands/browser,utils/configandutils/mcp-config— socket, daemon-spawn and POSIX file-permission assertions that do not hold on Windows. None are related to this change.node dist/index.js --help—discoveris gone; all 15 remaining commands still register.Repo-wide search for
discover(excludingnode_modules) returns zero matches.Migration
Use
brightdata searchto find sources andbrightdata scrapeto read them.Note for reviewers
I used a minor bump (0.3.3 → 0.4.0) since the package is pre-1.0 and there is no CHANGELOG in this repo to record the removal. Say the word if you would rather it be something else, or want a CHANGELOG started.
Out of scope
brightdata/skillsstill ships adiscover-apiskill whose CLI section documentsbdata discover, and itslive-researchandrag-pipelineskills are built on Discover. Those need a follow-up PR.