feat(http): build absolute request URL from relay_url - #725
Merged
Anshumancanrock merged 4 commits intoAug 13, 2026
Conversation
🦋 Changeset detectedLatest commit: 7d75692 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
coverage: 69.841% (+0.09%) from 69.749% — Anshumancanrock:feat/nip98-http-url into cameri:main |
cameri
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
getAbsoluteHttpRequestUrl()so callers can build the absolute HTTP URL that clients must sign in NIP-98u, using scheme + host frominfo.relay_urlonly (not the requestHostheader).Path still uses the existing public path prefix rules (
x-forwarded-prefixfrom a trusted proxy, elserelay_urlpathname) plusrequest.url.No admin middleware or Redis changes in this PR.
Related Issue
Prerequisite for NIP-98 admin API auth (follows #722 verifier). Next: Redis
SET NX, then admin middleware.Motivation and Context
NIP-98 binds the signed
utag to the request URL. If scheme/host came from the clientHostheader, an attacker could spoof it. Pinning toinfo.relay_urlkeeps URL binding operator-controlled.