ci(e2e): run expo native e2e flows with agent-device's maestro engine - #9443
Closed
wobsoriano wants to merge 2 commits into
Closed
ci(e2e): run expo native e2e flows with agent-device's maestro engine#9443wobsoriano wants to merge 2 commits into
wobsoriano wants to merge 2 commits into
Conversation
Replaces the Maestro CLI with agent-device (callstack/agent-device), whose test --maestro command runs the existing flow YAML through its own engine (XCTest on iOS, adb on Android) with a resident daemon instead of a JVM per invocation. Flow edits: launchApp.clearKeychain is unsupported (the runner script resets the simulator keychain instead), and the typed-email visibility assert is dropped because the field's floating label and value truncation make it unmatchable under this engine's Android tree.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2bdf3d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the Maestro CLI in the expo native e2e workflow with agent-device, whose
test --maestrocommand runs our existing Maestro flow YAML through its own engine (XCTest on iOS, adb on Android) with a resident daemon instead of a fresh JVM per invocation. Unlike the Argent migration (#9440), the flows stay in the Maestro format, no port to a new flow language.Flow changes are minimal and behavior-preserving:
launchApp.clearKeychainis unsupported by the engine (fails loudly at parse), so the runner script resets the simulator keychain up front instead, and the typed-email visibility assert is dropped because the field's floating label plus value truncation make it unmatchable under this engine's Android accessibility tree (a mangled identifier is still caught by the next screen's wait inside the retry).Runner scripts collapse into a single
agent-device test 'flows/*.yaml' --maestroinvocation per platform, with--retries 1and--artifacts-dirreplacing the hand-rolled per-flow retry loop and debug-output plumbing.Validated locally against the built SDK 57 fixture: iOS passes 6/6 first-attempt in 5m15s (the platform where Argent is hard-blocked). Android validation is still iterating locally; this draft exists to compare CI behavior and runtime against both the Maestro baseline and #9440.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change