Skip to content

refactor: fix phpstan errors in IncomingRequestTest - #10452

Open
paulbalandan wants to merge 1 commit into
codeigniter4:developfrom
paulbalandan:incoming-request-test
Open

refactor: fix phpstan errors in IncomingRequestTest#10452
paulbalandan wants to merge 1 commit into
codeigniter4:developfrom
paulbalandan:incoming-request-test

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Fixing the cluster of phpstan errors on IncomingRequestTest:

  • Type the property as IncomingRequest, treat one-off uses of Request via local $request
  • Add missing docblocks
  • I deleted a test that asserts PHP's behavior (throwing a TypeError on passing string to array). That is simply ridiculous as a test

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Aug 13, 2026
@paulbalandan
paulbalandan force-pushed the incoming-request-test branch from 30625ce to 74a7ae8 Compare August 13, 2026 12:18
@github-actions github-actions Bot added the stale Pull requests with conflicts label Aug 13, 2026
@github-actions

Copy link
Copy Markdown

👋 Hi, @paulbalandan!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code stale Pull requests with conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants