refactor: add precise return type to CodeIgniter::getPerformanceStats() - #10458
Open
soccerlover29 wants to merge 1 commit into
Open
refactor: add precise return type to CodeIgniter::getPerformanceStats()#10458soccerlover29 wants to merge 1 commit into
soccerlover29 wants to merge 1 commit into
Conversation
Adds an array shape docblock so PHPStan knows the return type is
array{startTime: float|null, totalTime: float} instead of a bare
array. Removes the now-unnecessary baseline suppression.
|
Hi there, soccerlover29! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a specific return-type annotation to CodeIgniter::getPerformanceStats() so static analysis knows exactly what's in the returned array (startTime: float|null and totalTime: float), instead of just "array". Removes the now-unneeded PHPStan baseline suppression for this method.
Contributes to #8732 (PHPStan "no value type specified in iterable type array" cleanup).
Checklist: