Skip to content

fix: suppress false-positive Snyk hardcoded-password finding - #121

Merged
reeshika-h merged 3 commits into
masterfrom
fix/snyk
Aug 10, 2026
Merged

fix: suppress false-positive Snyk hardcoded-password finding#121
reeshika-h merged 3 commits into
masterfrom
fix/snyk

Conversation

@reeshika-h

@reeshika-h reeshika-h commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Snyk Code (CWE-798) flagged a dummy test fixture value (validationErrors.put("password", "Password too short")) in TestError.java as a hardcoded password.
  • Added an inline // deepcode ignore HardcodedPassword: test fixture value, not a real secret suppression, since this is test data, not a real credential.

Verification

  • snyk code test — 0 active results (previously 1, in this file).
  • trufflehog filesystem . — 0 verified/unverified secrets across the repo.

Test plan

  • snyk code test passes clean
  • trufflehog scan clean
  • Reviewer confirms suppression reasoning

🤖 Generated with Claude Code

@reeshika-h @claude
fix: suppress false-positive Snyk hardcoded-password finding in TestE…
5ebe59d 
…rror

Snyk Code flagged the dummy test fixture value as a hardcoded password
(CWE-798). Annotate it with a deepcode ignore comment since it's a test
value, not a real credential. Verified with snyk code test and
trufflehog that no active/real secrets remain.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@reeshika-h
reeshika-h requested a review from a team as a code owner August 10, 2026 07:14
@snyk-io

snyk-io Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 0 ✅ Passed
🔵 Low Severity 0 0 0 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

cs-raj
cs-raj previously approved these changes Aug 10, 2026
View reviewed changes
OMpawar-21
OMpawar-21 previously approved these changes Aug 10, 2026
View reviewed changes
@reeshika-h @claude
fix: set up JDK 17 in SCA scan workflow
b17b1c2 
The Snyk Gradle scan job was failing with "Unsupported class file major
version 69" because no JDK was configured, so Gradle fell back to
whatever Java the runner defaults to. Explicitly set up JDK 17 to match
the project's sourceCompatibility and the JDK used in publish-release.yml.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@reeshika-h
reeshika-h dismissed stale reviews from OMpawar-21 and cs-raj via b17b1c2 August 10, 2026 07:30
@reeshika-h
reeshika-h requested a review from a team as a code owner August 10, 2026 07:30
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 0 ✅ Passed
🔵 Low Severity 0 0 0 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

1 similar comment
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 0 ✅ Passed
🔵 Low Severity 0 0 0 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 7 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 0
  • Medium without fixes: 7
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@reeshika-h
reeshika-h requested a review from OMpawar-21 August 10, 2026 07:57
@reeshika-h
reeshika-h merged commit 6ce10b7 into master Aug 10, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aravind-Kumar-cstk Aravind-Kumar-cstk Aravind-Kumar-cstk approved these changes
@cs-raj cs-raj cs-raj approved these changes
@OMpawar-21 OMpawar-21 OMpawar-21 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reeshika-h @Aravind-Kumar-cstk @cs-raj @OMpawar-21