Drop the polyfill for native workspace APIs - #12
Draft
grouville wants to merge 3 commits into
Draft
Conversation
The engine now covers everything this SDK used the polyfill for (dagger/dagger#13769): findConfigDirs is Workspace.findConfigDirs, and module sources load through Workspace.moduleSource with moduleName / introspectionSchemaJSON read off the native ModuleSource. generateModule also stops hand-building its changeset from raw directory diffs: it stages through Workspace.fork, so the changeset comes back measured from the caller's cwd and a change outside the cwd is a loud error — hand-built root-measured diffs used to land in the wrong place when generating from a subdirectory. The engineVersion bump and the dependency removal land together: the version gate scopes the engine's new changeset rooting to migrated modules. Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
Signed-off-by: Guillaume de Rouville <guillaume@dagger.io>
grouville
force-pushed
the
polyfill-removal
branch
from
August 11, 2026 23:44
fe5ef64 to
9631e88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Java SDK uses
dagger/polyfillto select its managed modules and return generated edits. Those behaviors now live in the engine through dagger/dagger#13854 and #13855, so this PR removes the wrapper and regenerates the committed SDK sources.The migration is intended to leave generation unchanged: the engine selects the modules registered for the Java SDK, and native
WorkspaceandModuleSourceAPIs return the generated files from the user's current directory.Running the full suite exposed two existing generator gaps in the current schema. Javadocs did not escape
*/inside glob examples, and GraphQLNodevalues could not be serialized as inputs. Both fixes are included because the regenerated SDK cannot compile correctly without them.What to review
Besides the direct polyfill replacement, the two generator fixes are the only behavior worth separate attention.
Test
dagger checkAll 31 checks pass, including parent/module-directory generation, nested chains, init, sdk-sdk contracts, and module loading. The provisional engine version will be updated before merge.