acc: merge identical terraform/direct request goldens into single files - #6249
Open
janniklasrose wants to merge 4 commits into
Open
acc: merge identical terraform/direct request goldens into single files#6249janniklasrose wants to merge 4 commits into
janniklasrose wants to merge 4 commits into
Conversation
## Changes Bump the pinned Databricks Terraform provider from v1.124.0 to v1.125.0. Notable schema changes: - The provider no longer issues a `GET /api/2.0/preview/scim/v2/Me` request during deploy/destroy/plan. ## Tests Acceptance goldens regenerated via `./task test-update`. Co-authored-by: Isaac
## Changes Bump `github.com/databricks/databricks-sdk-go` from v0.166.0 to v0.169.0. - `secrets-uc` graduated out of Public Preview (help text and bundle schema). - Pipeline ingestion fanout options promoted from Private Preview to Beta. - New output-only `resources.jobs.*.trigger_state.pause_status` field. The SDK's breaking removals (iamv2 `InternalId`, catalog provider credential fields) and the `bundledeployments` `State` type changes are not referenced by the CLI, so no code changes were required. ## Tests Acceptance goldens regenerated via `./task test-update`. Co-authored-by: Isaac
Several acceptance tests recorded per-engine golden files (out.X.terraform.* and out.X.direct.*) that are byte-identical because the operation is engine-independent. Merge each such pair into a single engine-agnostic out.X.* file and drop the $DATABRICKS_BUNDLE_ENGINE suffix from the script's redirect. Only files written by a dedicated redirect in the test's own script are merged. Files produced by the shared permissions _script or the postgres_projects print_requests helper (which also emit genuinely per-engine-differing files), and files consumed by the Phase-1 user_agent and permissions analyzers (verify.py / analyze_requests.py parse the engine from the filename), are intentionally left per-engine. Follow-up to review feedback on #6246. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 60fb1c7
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 24 slowest tests (at least 2 minutes):
|
janniklasrose
enabled auto-merge
August 12, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to @denik's review feedback on #6246: where a test records per-engine golden files (
out.X.terraform.*/out.X.direct.*) that are byte-identical — because the operation is engine-independent — merge each pair into a single engine-agnosticout.X.*file and drop the$DATABRICKS_BUNDLE_ENGINEsuffix from the script's redirect.21 pairs across 19 tests are merged. Scope was deliberately limited to files written by a dedicated redirect in the test's own script. Intentionally left per-engine:
bundle/resources/permissions/_scriptand thepostgres_projectsprint_requests()helper — those same lines also emit genuinely per-engine-differing files, so the suffix must stay.Phase = 1analyzersuser_agent/verify.pyandpermissions/analyze_requests.py, which parse the engine from the filename (a file without.terraform./.direct.is skipped) — merging would silently drop them from the analysis.Tests
Acceptance goldens regenerated via
./task test-update; full localTestAcceptverify pass is green (the one flaky 60s timeout inpermissions/pipelines/update, a test untouched here, passes when run alone). Cloud-only tests are verified by integration CI.This pull request and its description were written by Isaac.