fix(hub-ui): observe dock sidebar size in the popup's own realm - #218
Merged
Conversation
Port of vitejs/devtools#521. In popup dock mode the sidebar's ResizeObserver was bound implicitly to the host window via useElementBounding, so resizing the popup didn't update the group rail (collapsing into the overflow "more" icon, or restoring hidden icons) until the mouse moved back into the host page. Bind the observer through the sidebar element's own document/window instead. Co-authored-by: SaKaNa-Y <185575200+SaKaNa-Y@users.noreply.github.com>
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports vitejs/devtools#521 (by @SaKaNa-Y) to this repo's fork of the dock sidebar.
In popup dock mode, resizing the popup window didn't update the dock sidebar group rail immediately:
Root cause
DockGroupSidebar.vuemeasured its height withuseElementBounding, which listens forresizeon the globalwindow— the host page's window. In popup dock mode the sidebar renders inside the popup's own realm (its owndocument/window), so resizing the popup never fired that listener; the size only updated on the next event that happened to touch the host window (e.g. a mousemove there).Fix
Same approach as the upstream fix: bind a
ResizeObserverdirectly to the sidebar element viaelement.ownerDocument.defaultView.ResizeObserver, so it observes in whichever realm the element actually lives in, falling back toglobalThis.ResizeObserverwhen unavailable.Closes #207.
Diff for reference: https://github.com/vitejs/devtools/pull/521/files
PR generated with the help of an agent.