fix(hub-ui): prevent edge dock panel from scrolling its toolbar out of view - #220
Merged
Conversation
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…f view Ports vitejs/devtools#522 by @SaKaNa-Y, adapted for the DockEdge.vue that landed here in the v0.9 migration. Swaps overflow-hidden for overflow-clip on the edge dock panel and its content region so the toolbar can no longer be scrolled out of view when opening a large view like the Vite/Rolldown Modules Graph. Co-authored-by: SaKaNa-Y <185575200+SaKaNa-Y@users.noreply.github.com>
antfubot
force-pushed
the
small-moments-refuse
branch
from
August 14, 2026 05:53
54f375c to
108c816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports vitejs/devtools#522 by @SaKaNa-Y ("fix(core): prevent edge dock panel from scrolling its toolbar out of view"), adapted for
packages/hub-ui/src/client/components/dock/DockEdge.vue— the equivalent ofpackages/core/src/client/webcomponents/components/dock/DockEdge.vueafter the v0.9 migration.Fixes #208.
Swaps
overflow-hiddenforoverflow-clipon the edge dock panel and its content region, isolating the toolbar from the scrollable content area so opening a large view (e.g. the Vite/Rolldown Modules Graph) no longer scrolls the toolbar out of view. Also regenerated the shadow-root stylesheet (packages/hub-ui/src/client/.generated/css.ts) viapnpm run build:cssto pick up the new class.Credit to @SaKaNa-Y for the original fix.
Closes #208.