Jeremypw/format bar/use language action - #1796
Draft
jeremypw wants to merge 16 commits into
Draft
Conversation
# Conflicts: # src/Widgets/FormatBar.vala
Collaborator
Author
|
@danirabbit I spent quite a while trying to get this to work and this is the best I can do. Grouped radiobuttons emit a spurious state changed signal on the deselected item it seems and it is hard to avoid endless loops. Hopefully it will work better in Gtk4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to finish #1775 after merging master and fixing conflicts
For some reason that is not clear to me, the list row widget only behaved (nearly) as expected if a CheckButton is used instead of an ungrouped RadioButton in that the state reflects whether the target matches the current language id on startup. With ungrouped RadioButtons they are all on.
There is currently a flaw in that clicking on a selected checkbutton deactivates it but does not change the current language. We may have to revert to grouped RadioButtons?
A number of other small fixes and cleanups are made which could be merged even if this is abandoned.