Skip to content

dataconnect.py: update "X-Client-Version" header value to match the Python/Admin/{version} convention - #975

Merged
dconeybe merged 1 commit into
winefrom
dconeybe/wine/ClientVersionConformance
Aug 13, 2026
Merged

dataconnect.py: update "X-Client-Version" header value to match the Python/Admin/{version} convention#975
dconeybe merged 1 commit into
winefrom
dconeybe/wine/ClientVersionConformance

Conversation

@dconeybe

Copy link
Copy Markdown

No description provided.

@dconeybe dconeybe self-assigned this Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the X-Client-Version header format in the Data Connect client from python/{version} to Python/Admin/{version} and updates the corresponding unit test assertion to match this change. There are no review comments, and the changes look correct and complete, so I have no feedback to provide.

@dconeybe
dconeybe requested a review from stephenarosaj August 13, 2026 17:37

@stephenarosaj stephenarosaj left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe
dconeybe merged commit 2364de0 into wine Aug 13, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants