ref(logging): [Logs and Metrics Enable Flags 21] Rename Logs opt-ins - #5970
Draft
adinauer wants to merge 1 commit into
Draft
ref(logging): [Logs and Metrics Enable Flags 21] Rename Logs opt-ins#5970adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
Use state-oriented names for the new Logback, Log4j2, JUL, Timber, Logcat, and Spring Boot Logs controls. Expose get...Enabled accessors so Java-defined options map to natural Kotlin properties before these APIs are released. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
This was referenced Aug 14, 2026
runningcode
approved these changes
Aug 14, 2026
runningcode
left a comment
Contributor
There was a problem hiding this comment.
Yes! Much better API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Logs and Metrics Enable Flags)
📜 Description
Renames the generic logging-integration opt-in from
enableLogstologsEnabledbefore the new API is released:<logsEnabled>true</logsEnabled>logsEnabled="true"LogManager:io.sentry.jul.SentryHandler.logsEnabled=truesentry.logging.logs-enabled=truelogsEnabledtimberLogsEnabledlogcatLogsEnabledJava integrations expose state-oriented
get...Enabled()andset...Enabled()accessors, which map to natural.logsEnabled,.timberLogsEnabled, and.logcatLogsEnabledproperty syntax in Kotlin. Samples, tests, API dumps, and option guidance use the renamed controls.Legacy aggregate
ExternalOptions.enableLogsdetection remains unchanged because it exists only to warn about obsoletelogs.enabledconfiguration. The Android manifest keys remainio.sentry.timber.logs.enabledandio.sentry.logcat.logs.enabled.💡 Motivation and Context
logsEnableddescribes state rather than an action and provides a consistent.logsEnabledproperty across Kotlin-native and Java-defined integrations.💚 How did you test it?
./gradlew :sentry-logback:test :sentry-log4j2:test :sentry-jul:test :sentry-android-timber:testReleaseUnitTest :sentry-android-core:testReleaseUnitTest :sentry-spring-boot:test :sentry-spring-boot-jakarta:test :sentry-spring-boot-4:test./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.#skip-changelog