ref(browser): Tree-shake span streaming out of error-only bundles - #23362
Open
Lms24 wants to merge 5 commits into
Open
ref(browser): Tree-shake span streaming out of error-only bundles#23362Lms24 wants to merge 5 commits into
Lms24 wants to merge 5 commits into
Conversation
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/ref-browser-treeshake-span-streaming
branch
from
August 12, 2026 16:50
b7fb94f to
eb0bfb1
Compare
Lms24
commented
Aug 12, 2026
Lms24
force-pushed
the
lms/ref-browser-treeshake-span-streaming
branch
from
August 13, 2026 11:46
54073b4 to
113a8da
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 113a8da. Configure here.
`init()` no longer pushes `spanStreamingIntegration()`. That single reference was the only thing retaining `SpanBuffer`, `captureSpan`, `estimateSize` and `scopeContextAttributes` in every browser bundle, including bundles for apps that never use tracing. Instead, browser-facing packages import their span-start APIs from `@sentry/core/browser`, which installs the integration on the client before the first span starts. A span can only end if it was started, so the `afterSpanEnd` listener is always registered in time. `init` alone drops from 28.52 kB to 26.95 kB gzipped, within 0.1 kB of the `__SENTRY_TRACING__: false` floor. Tracing users pay nothing extra. Both variants share their names, so a stray plain import compiles fine and silently stops sending spans. `sdk/no-unguarded-span-apis` is the only thing that catches that, hence it lands here rather than later. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/ref-browser-treeshake-span-streaming
branch
from
August 13, 2026 16:36
113a8da to
99e50de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the prework in #23361, this PR:
@sentry/core/browserspanStreamingIntegrationduring SDK setup and fully relies on span starting APIs to add the integration if it wasn't added yetOne special change for
@sentry/effect: I had to create browser- and server-specific versions of theSentryEffectTracerwhich takes the respective span starting APIs. We now have a factory function that creates the tracer for both environments specifically that injects the respective span API.all credits to @mydea for the idea 🙏