Skip to content

ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE - #23368

Draft
RulaKhaled wants to merge 1 commit into
developfrom
feat/segment-name-source-impl
Draft

ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE#23368
RulaKhaled wants to merge 1 commit into
developfrom
feat/segment-name-source-impl

Conversation

@RulaKhaled

@RulaKhaled RulaKhaled commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Besides removing SEMANTIC_ATTRIBUTE_SENTRY_SOURCE and using SENTRY_SEGMENT_NAME_SOURCE instead, this PR also:

  • Sets name source only on segment spans (per the Sentry segment name source convention) — e.g. updateName, HTTP server spans, and tRPC when it is the segment root
  • Removes envelope-time backfill from sentry.source → sentry.segment.name.source in captureSpan

CI note: This PR alone is expected to fail CI. It will stay blocked until #23367 is merged into it — that split is intentional to keep the core changes easier to review.

Fixes #22259

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 30.27 kB -0.1% -29 B 🔽
@sentry/browser - with treeshaking flags 28.44 kB -0.12% -32 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing 26.81 kB -0.03% -6 B 🔽
@sentry/browser (incl. Tracing) 48.53 kB -0.03% -10 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 48.55 kB -0.01% -4 B 🔽
@sentry/browser (incl. Tracing, Profiling) 51.41 kB -0.04% -20 B 🔽
@sentry/browser (incl. Tracing, Replay) 87.93 kB -0.01% -8 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.36 kB +0.05% +35 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 92.66 kB -0.01% -8 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 105.38 kB +0.02% +17 B 🔺
@sentry/browser (incl. Feedback) 47.61 kB -0.08% -37 B 🔽
@sentry/browser (incl. sendFeedback) 35.1 kB -0.08% -27 B 🔽
@sentry/browser (incl. FeedbackAsync) 40.25 kB -0.07% -27 B 🔽
@sentry/browser (incl. Metrics) 31.19 kB -0.18% -55 B 🔽
@sentry/browser (incl. Logs) 31.47 kB -0.16% -48 B 🔽
@sentry/browser (incl. Metrics & Logs) 32.1 kB -0.14% -45 B 🔽
@sentry/react 32.05 kB -0.13% -40 B 🔽
@sentry/react (incl. Tracing) 50.73 kB +0.01% +1 B 🔺
@sentry/vue 35.32 kB +0.04% +11 B 🔺
@sentry/vue (incl. Tracing) 50.49 kB -0.02% -6 B 🔽
@sentry/svelte 30.3 kB -0.11% -32 B 🔽
CDN Bundle 31.57 kB -0.12% -37 B 🔽
CDN Bundle (incl. Tracing) 48.86 kB -0.02% -6 B 🔽
CDN Bundle (incl. Logs, Metrics) 33.76 kB -0.12% -38 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 50.78 kB -0.03% -14 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 74.3 kB -0.02% -10 B 🔽
CDN Bundle (incl. Tracing, Replay) 86.44 kB -0.03% -18 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.3 kB +0.02% +11 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 92.16 kB -0.01% -7 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.09 kB -0.03% -19 B 🔽
CDN Bundle - uncompressed 93.76 kB -0.09% -83 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 146.69 kB -0.03% -30 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.06 kB -0.09% -83 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.38 kB -0.02% -30 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.02 kB -0.03% -57 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.97 kB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.65 kB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.67 kB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.34 kB -0.01% -4 B 🔽
@sentry/nextjs (client) 53.28 kB +0.05% +25 B 🔺
@sentry/sveltekit (client) 48.95 kB -0.03% -11 B 🔽
@sentry/core/server 65.37 kB +0.06% +34 B 🔺
@sentry/core/browser 51.72 kB +0.06% +31 B 🔺
@sentry/node 117.93 kB -0.01% -6 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.03 kB -0.03% -24 B 🔽
@sentry/aws-serverless 91.46 kB -0.01% -5 B 🔽
@sentry/cloudflare (withSentry) - minified 214.08 kB +0.05% +88 B 🔺
@sentry/cloudflare (withSentry) 528.61 kB -0.04% -161 B 🔽

View base workflow run

@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-impl branch from 16a4997 to f187f70 Compare August 12, 2026 14:08
@RulaKhaled RulaKhaled changed the title ref!: Migrate to SENTRY_SEGMENT_NAME_SOURCE ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE Aug 12, 2026
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-impl branch 2 times, most recently from 7f6cf2b to 5a7db5d Compare August 13, 2026 09:22
Replace sentry.source with sentry.segment.name.source and set the
attribute only on segment spans.

Fixes #22259
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-impl branch from 5a7db5d to 9c2caf1 Compare August 13, 2026 09:47
@RulaKhaled

Copy link
Copy Markdown
Collaborator Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9c2caf1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename SEMANTIC_ATTRIBUTE_SENTRY_SOURCE to sentry.segment.name.source & drop semanticAttributes re-export

1 participant