feat(react-router)!: Remove unstable_sentryVitePluginOptions - #23374
Merged
chargome merged 1 commit intoAug 13, 2026
Conversation
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 09:28
aa5d1e9 to
2200de9
Compare
Contributor
size-limit report 📦
|
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 09:44
2200de9 to
9fbbb98
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 10:02
9fbbb98 to
e467eb0
Compare
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 10:56
e467eb0 to
57a4e9d
Compare
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 11:45
57a4e9d to
fe86f1a
Compare
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 12:26
fe86f1a to
4cc6f3a
Compare
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
2 times, most recently
from
August 13, 2026 12:48
ef17260 to
488405f
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 488405f. Configure here.
| // same handling as in bundler plugins: https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/05084f214c763a05137d863ff5a05ef38254f68d/packages/bundler-plugin-core/src/build-plugin-manager.ts#L102-L103 | ||
| project: Array.isArray(project) ? project[0] : project, | ||
| project, | ||
| url: sentryUrl, |
There was a problem hiding this comment.
Silent option skipped for CLI upload
Medium Severity
Top-level silent is passed through to the Vite plugin but not to the SentryCli instance that injects debug IDs and uploads source maps. After the hatch was removed, that flag no longer reaches the CLI, so upload-path logs keep printing even when silent is set.
Reviewed by Cursor Bugbot for commit 488405f. Configure here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 13:17
488405f to
3f1ce8b
Compare
chargome
marked this pull request as ready for review
August 13, 2026 13:45
chargome
requested review from
mydea and
s1gr1d
and removed request for
a team
August 13, 2026 13:45
s1gr1d
approved these changes
Aug 13, 2026
s1gr1d
left a comment
s1gr1d
left a comment
Member
There was a problem hiding this comment.
Looks good, but there are some comments about self-hosted which seem more like part of a debugging-observation than a prominent comment we need to point out (but treat this as L, this can still be merged)
Comment on lines
+49
to
+50
| // `url` and `headers` previously only reached the CLI through `unstable_sentryVitePluginOptions`, | ||
| // so self-hosted setups had no supported way to point this upload at their instance. |
Member
There was a problem hiding this comment.
not sure if this comment is needed here - without looking at this PR, this feels a bit out of place
chargome
deleted the
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptions
branch
August 13, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
unstable_sentryVitePluginOptionsfrom the React Router build options.Net deletion of ~430 lines: the hatch could contradict
sentryOnBuildEnd, so a guard, aconsole.warnand an "explicitundefinederases the unstable value" workaround all existed purely to contain it. All three go.While removing it,
sentryUrlandheadersturned out to reach theSentryCliconstructor only through the hatch, so self-hosted setups had no supported way to point the buildEnd upload at their instance. They are now read from the top-level config — thereact-router-sourcemapse2e app depended on exactly this, viaunstable_sentryVitePluginOptions.url.Tests asserting hatch-vs-top-level precedence are deleted; the ones asserting real invariants (source maps stay disabled for the Vite plugin,
filesToDeleteAfterUploadnever forwarded,metaFrameworkpinned) are rewritten against top-level options. The #22929 regression coverage is preserved in both the unit tests and the e2e app.Fixes #23344