Skip to content

feat(solidstart)!: Align v1 build options with BuildTimeOptionsBase - #23388

Merged
chargome merged 1 commit into
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptionsfrom
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
Aug 13, 2026
Merged

feat(solidstart)!: Align v1 build options with BuildTimeOptionsBase#23388
chargome merged 1 commit into
charlygomez/js-3360-react-router-remove-unstable_sentryvitepluginoptionsfrom
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase

Conversation

@chargome

@chargome chargome commented Aug 13, 2026

Copy link
Copy Markdown
Member

SolidStart has two entry points. sentrySolidStart() (v2) already uses BuildTimeOptionsBase; sentrySolidStartVite() / withSentry() (v1) used a hand-rolled type with no applicationKey, making unstable_sentryVitePluginOptions the only way to reach it. Both majors stay supported in v11, so v1 converges onto the shared type rather than being dropped.

sourceMapsUploadOptions moves to the top level, and enabled: false becomes sourcemaps: { disable: true } (inverted). v1 gains applicationKey, sentryUrl, headers, silent, errorHandler, release and moduleMetadata.

The unstable_ hatch stays functional here and only changes location — its removal is a separate PR, so this one is reviewable as a pure type migration.

Breaking change for SolidStart v1 users; migration guide entry included.

Fixes #23341

@linear-code

linear-code Bot commented Aug 13, 2026

Copy link
Copy Markdown

JS-3357

@chargome chargome self-assigned this Aug 13, 2026
@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from d26ee43 to 1d8529f Compare August 13, 2026 09:28
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.3 kB - -
@sentry/browser - with treeshaking flags 28.47 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.81 kB - -
@sentry/browser (incl. Tracing) 48.54 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.55 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.43 kB - -
@sentry/browser (incl. Tracing, Replay) 87.94 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.32 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.67 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.36 kB - -
@sentry/browser (incl. Feedback) 47.65 kB - -
@sentry/browser (incl. sendFeedback) 35.13 kB - -
@sentry/browser (incl. FeedbackAsync) 40.28 kB - -
@sentry/browser (incl. Metrics) 31.24 kB - -
@sentry/browser (incl. Logs) 31.52 kB - -
@sentry/browser (incl. Metrics & Logs) 32.15 kB - -
@sentry/react 32.09 kB - -
@sentry/react (incl. Tracing) 50.73 kB - -
@sentry/vue 35.31 kB - -
@sentry/vue (incl. Tracing) 50.5 kB - -
@sentry/svelte 30.33 kB - -
CDN Bundle 31.61 kB - -
CDN Bundle (incl. Tracing) 48.87 kB - -
CDN Bundle (incl. Logs, Metrics) 33.8 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.79 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.31 kB - -
CDN Bundle (incl. Tracing, Replay) 86.46 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.29 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.16 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.11 kB - -
CDN Bundle - uncompressed 93.84 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.72 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.14 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.41 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.08 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.98 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.65 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.68 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.34 kB - -
@sentry/nextjs (client) 53.26 kB - -
@sentry/sveltekit (client) 48.96 kB - -
@sentry/core/server 65.34 kB - -
@sentry/core/browser 51.69 kB - -
@sentry/node 117.67 kB +0.01% +1 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.06 kB - -
@sentry/aws-serverless 91.47 kB - -
@sentry/cloudflare (withSentry) - minified 213.99 kB - -
@sentry/cloudflare (withSentry) 528.78 kB - -

View base workflow run

@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from 1d8529f to d6f0dc8 Compare August 13, 2026 09:44
@chargome

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit d6f0dc8. Configure here.

@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from d6f0dc8 to bcabd60 Compare August 13, 2026 10:02
@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from bcabd60 to 47a7908 Compare August 13, 2026 10:56
@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from 47a7908 to 73821af Compare August 13, 2026 11:46
@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from 73821af to f4f707e Compare August 13, 2026 12:26
@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from f4f707e to 9b5b2c4 Compare August 13, 2026 12:32
@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from 9b5b2c4 to 7a64570 Compare August 13, 2026 12:48
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@chargome
chargome force-pushed the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch from 7a64570 to fd2cea5 Compare August 13, 2026 13:17
@chargome
chargome marked this pull request as ready for review August 13, 2026 13:45
@chargome
chargome requested a review from a team as a code owner August 13, 2026 13:45
@chargome
chargome requested review from andreiborza, mydea and s1gr1d and removed request for a team August 13, 2026 13:45
@chargome
chargome requested a review from nicohrubec August 13, 2026 13:48
@chargome
chargome merged commit 1e55b01 into develop Aug 13, 2026
201 checks passed
@chargome
chargome deleted the charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase branch August 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

solidstart: Align v1 build options with BuildTimeOptionsBase

2 participants