feat(solidstart)!: Align v1 build options with BuildTimeOptionsBase - #23388
Merged
Conversation
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 09:28
d26ee43 to
1d8529f
Compare
Contributor
size-limit report 📦
|
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 09:44
1d8529f to
d6f0dc8
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d6f0dc8. Configure here.
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 10:02
d6f0dc8 to
bcabd60
Compare
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 10:56
bcabd60 to
47a7908
Compare
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 11:46
47a7908 to
73821af
Compare
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 12:26
73821af to
f4f707e
Compare
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 12:32
f4f707e to
9b5b2c4
Compare
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 12:48
9b5b2c4 to
7a64570
Compare
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
from
August 13, 2026 13:17
7a64570 to
fd2cea5
Compare
chargome
marked this pull request as ready for review
August 13, 2026 13:45
chargome
requested review from
andreiborza,
mydea and
s1gr1d
and removed request for
a team
August 13, 2026 13:45
s1gr1d
approved these changes
Aug 13, 2026
chargome
deleted the
charlygomez/js-3357-solidstart-align-v1-build-options-with-buildtimeoptionsbase
branch
August 13, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SolidStart has two entry points.
sentrySolidStart()(v2) already usesBuildTimeOptionsBase;sentrySolidStartVite()/withSentry()(v1) used a hand-rolled type with noapplicationKey, makingunstable_sentryVitePluginOptionsthe only way to reach it. Both majors stay supported in v11, so v1 converges onto the shared type rather than being dropped.sourceMapsUploadOptionsmoves to the top level, andenabled: falsebecomessourcemaps: { disable: true }(inverted). v1 gainsapplicationKey,sentryUrl,headers,silent,errorHandler,releaseandmoduleMetadata.The
unstable_hatch stays functional here and only changes location — its removal is a separate PR, so this one is reviewable as a pure type migration.Breaking change for SolidStart v1 users; migration guide entry included.
Fixes #23341