feat(solidstart)!: Remove unstable_sentryVitePluginOptions - #23389
Merged
Conversation
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 09:28
59ebdb3 to
19abb0b
Compare
Contributor
size-limit report 📦
|
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 09:44
19abb0b to
4c4174b
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4c4174b. Configure here.
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 10:02
4c4174b to
7d0cb3f
Compare
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 10:56
7d0cb3f to
35b69ab
Compare
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 11:46
35b69ab to
ce2614e
Compare
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 12:26
ce2614e to
4263ce2
Compare
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 12:32
4263ce2 to
b2f8a33
Compare
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 12:48
b2f8a33 to
de24fc7
Compare
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
from
August 13, 2026 13:17
de24fc7 to
de27976
Compare
chargome
marked this pull request as ready for review
August 13, 2026 13:45
chargome
requested review from
andreiborza,
mydea and
s1gr1d
and removed request for
a team
August 13, 2026 13:45
chargome
deleted the
charlygomez/js-3362-solidstart-remove-unstable_sentryvitepluginoptions
branch
August 13, 2026 15:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
unstable_sentryVitePluginOptionsfrom both SolidStart entry points —sentrySolidStartVite()/withSentry()(v1) andsentrySolidStart()(v2). They sharesourceMaps.ts, so splitting this per-major would leave the file half-migrated.Everything the hatch exposed is reachable as a top-level build option after the preceding v1 alignment PR. Adds a build-time warning on both entry points.
Fixes #23346