feat(bundler-plugins)!: Migrate from @sentry/cli to the sentry CLI SDK - #23398
Draft
JPeer264 wants to merge 1 commit into
Draft
feat(bundler-plugins)!: Migrate from @sentry/cli to the sentry CLI SDK#23398JPeer264 wants to merge 1 commit into
JPeer264 wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
Replace the @sentry/cli v2 binary wrapper with the programmatic SDK (createSentrySDK) exposed by the new sentry CLI package. A SentryCliAdapter in src/core/cli.ts maps the plugin's structured option shapes onto the SDK's typed methods, keeping all translation in one place: - release create/finalize/set-commits/deploy and sourcemap upload now go through the SDK instead of spawning the CLI binary; one SDK client is created per (options, project) pair since project selection is bound at client creation time - the integration-test fixtures replace the @sentry__cli.patch with a local sentry-stub fixture recording CLI invocations to sentry-cli-mock.json, so upload assertions no longer depend on the binary's internals - remix's release/sourcemap scripts and react-router's buildEnd hook are migrated to the same SDK - add a react-router-7-sourcemaps e2e test app covering the new upload path against a mock Sentry server Requires sentry >= 0.41.0: earlier 0.x builds had a link-fatal named import of Node 22.15+ zstd builtins in the ESM entry, which crashed the whole module on Node 18/20. Co-Authored-By: Claude <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/cli-v3-migration
branch
from
August 13, 2026 14:31
6091f43 to
6a8fbbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18518
closes JS-1312
This PR is removing
@sentry/cliin favor ofsentry.Following was done:
SentryCliAdapterto make the usage a little bit more comfortable (especially around uploading sourcemaps for more projects).run()for therelease.deploycommand (this should be fixed with fix(sdk): pass each positional argument as its own argv token cli#1415)sentryCliBinaryExists, because there is no binary anymoreClanker description:
Replace the @sentry/cli v2 binary wrapper with the programmatic SDK (createSentrySDK) exposed by the new sentry CLI package. A SentryCliAdapter in src/core/cli.ts maps the plugin's structured option shapes onto the SDK's typed methods, keeping all translation in one place:
Requires sentry >= 0.41.0: earlier 0.x builds had a link-fatal named import of Node 22.15+ zstd builtins in the ESM entry, which crashed the whole module on Node 18/20.