chore: Drop enable_logs, enable_metrics options in new major - #7178
chore: Drop enable_logs, enable_metrics options in new major#7178sentrivana wants to merge 3 commits into
enable_logs, enable_metrics options in new major#7178Conversation
Codecov Results 📊✅ 107202 passed | ⏭️ 5465 skipped | Total: 112667 | Pass Rate: 95.15% | Execution Time: 383m 3s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2261 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.23% 90.55% +0.32%
==========================================
Files 193 185 -8
Lines 25361 23934 -1427
Branches 9302 8816 -486
==========================================
+ Hits 22883 21673 -1210
- Misses 2478 2261 -217
- Partials 1432 1372 -60Generated by Codecov Action |
ericapisani
left a comment
ericapisani
left a comment
There was a problem hiding this comment.
Other than the one note for our guidance in the migration guide, this LGTM
| - Removed the RedisIntegration `max_data_size` option. | ||
| - Removed the possibility to supply a specific client to the LaunchDarklyIntegration. | ||
| - The `enable_tracing` option was removed. Use `traces_sample_rate=1.0` instead. | ||
| - The `enable_logs` option was removed. Using Sentry's logging API now works without requiring setting `enable_logs=True`. Automatic capture of logs emitted by the `logging` standard library module or Loguru can be turned on by providing the `capture_sentry_logs=True` option to either `LoggingIntegration` or `LoguruIntegration`: |
There was a problem hiding this comment.
Automatic capture of logs emitted by the
loggingstandard library module or Loguru can be turned on by providing thecapture_sentry_logs=Trueoption to eitherLoggingIntegrationorLoguruIntegration
GivenLoggingIntegration and LoguruIntegration are both auto-enabling integrations, I wonder if it might be more useful to give an example for opting out rather than opting in.
2 participants
The options were deprecated with 2fef9bc.