fix(presets): reject falsy malformed catalog roots on load - #4088
Open
marcelsafin wants to merge 1 commit into
Open
fix(presets): reject falsy malformed catalog roots on load#4088marcelsafin wants to merge 1 commit into
marcelsafin wants to merge 1 commit into
Conversation
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects preset catalog parsing so falsy malformed YAML roots are rejected while empty/null documents remain no-ops.
Changes:
- Distinguishes
Nonefrom other falsy YAML values. - Adds regression coverage for lists, booleans, numbers, and strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/specify_cli/presets/__init__.py |
Validates all present catalog roots as mappings. |
tests/test_presets.py |
Tests rejection of falsy non-mapping roots. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PresetCatalog._load_catalog_config()usedyaml.safe_load(...) or {}, so falsy non-mapping documents such as[],0,false, and an empty string were silently accepted as empty configuration. That hides corrupt catalog files and makes them behave differently from truthy malformed roots.This preserves the existing empty/null no-op while rejecting every present non-mapping root consistently.
Testing
uv run specify --helpuv sync && uv run pytest(6,655 passed, 177 skipped)uvx ruff@0.15.0 check src testscleanAI Disclosure
Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; failing regressions were added before the fix, then the full suite and lint were run locally. Commit includes
Assisted-byandCo-authored-bytrailers.