fix(bundler): reject non-string manifest list members - #4091
Open
marcelsafin wants to merge 2 commits into
Open
Conversation
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Validates manifest string-array members instead of coercing invalid values.
Changes:
- Rejects non-string
tags, tools, and MCP entries. - Adds contract regression tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/specify_cli/bundler/models/manifest.py |
Enforces string-only list members. |
tests/contract/test_manifest_schema.py |
Tests invalid member rejection. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if isinstance(raw, (str, bytes)) or not isinstance(raw, (list, tuple)): | ||
| raise BundlerError(f"'{field_name}' must be a list of strings when present.") | ||
| return tuple(str(item) for item in raw) | ||
| if any(not isinstance(item, str) for item in raw): |
Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bundle manifest fields declared as string arrays (
tags,requires.tools, andrequires.mcp) currently coerce every member withstr(). Invalid values such as integers, booleans, and objects therefore enter the model as plausible strings instead of failing schema validation.This validates each member and preserves valid strings without coercion.
Testing
uv run specify --helpuv sync && uv run pytest(6,654 passed, 177 skipped)uvx ruff@0.15.0 check src testscleanAI Disclosure
Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; failing contract regressions were added before the fix, then the full suite and lint were run locally. Commit includes
Assisted-byandCo-authored-bytrailers.