Skip to content

test: pin EvalCase session state injection into agent instructions - #6705

Open
sgoel2be24-cyber wants to merge 4 commits into
google:mainfrom
sgoel2be24-cyber:fix/eval-instruction-session-state
Open

test: pin EvalCase session state injection into agent instructions#6705
sgoel2be24-cyber wants to merge 4 commits into
google:mainfrom
sgoel2be24-cyber:fix/eval-instruction-session-state

Conversation

@sgoel2be24-cyber

Copy link
Copy Markdown
Contributor

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

Problem:
Eval tools already saw EvalCase.session_input.state, but instruction templates with {some_key} historically did not during eval.

Solution:
Current main already runs inject_session_state for string instructions in the eval Runner. This PR adds a LocalEvalService regression so that path cannot silently break.

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

1 passedtests/unittests/evaluation/test_local_eval_service.py::test_eval_injects_session_input_state_into_instruction

Manual End-to-End (E2E) Tests:

Not applicable: this is a unit regression for eval instruction injection. No runtime/CLI surface change.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Additional context

Assistance: drafted with an AI coding agent and reviewed before opening.

Made with Cursor

@adk-bot adk-bot added the eval [Component] This issue is related to evaluation label Aug 13, 2026
@google-cla

google-cla Bot commented Aug 13, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Eval tools already saw session_input.state while instruction templates
historically did not (google#5037). Current main injects
correctly; this locks that path so it cannot regress.
@sgoel2be24-cyber
sgoel2be24-cyber force-pushed the fix/eval-instruction-session-state branch from 6c8e083 to d59c1fc Compare August 13, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval [Component] This issue is related to evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EvalCase session state data does not seem to be propagated

3 participants