-
Notifications
You must be signed in to change notification settings - Fork 87
Fixes of another failing integration tests #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mawilk90
wants to merge
10
commits into
linode:dev
Choose a base branch
from
mawilk90:hotfix/integration-tests-fixes
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
78b3278
Increase timeout for get_domain_status
mawilk90 cabdc62
Mark test_latest_get_event as flaky and increase latest_events list
mawilk90 8b2165a
Merge branch 'dev' into hotfix/integration-tests-fixes
mawilk90 08053bc
Add condition to get different region for migration
mawilk90 702826d
Add skip for test_get_login due to ongoing issue for TPT user
mawilk90 265d3d3
Increase timeouts in test_create_and_delete_vlan
mawilk90 bd261c9
Add try-except clause to create_image_id fixture
mawilk90 a429b98
Modify condition to get different region for migration
mawilk90 cd9935a
Merge branch 'dev' into hotfix/integration-tests-fixes
mawilk90 64ba0ad
Update skip reason content in test_get_login
mawilk90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
|
|
||
| import pytest | ||
|
|
||
| from linode_api4.errors import ApiError | ||
| from linode_api4.objects import ( | ||
| Image, | ||
| ImageShareGroup, | ||
|
|
@@ -33,7 +34,7 @@ def wait_for_image_status( | |
| ) | ||
|
|
||
|
|
||
| @pytest.fixture(scope="class") | ||
| @pytest.fixture(scope="module") | ||
| def sample_linode(test_linode_client, e2e_test_firewall): | ||
| client = test_linode_client | ||
| region = get_region(client, {"Linodes", "Cloud Firewall"}, site_type="core") | ||
|
|
@@ -50,15 +51,22 @@ def sample_linode(test_linode_client, e2e_test_firewall): | |
| linode_instance.delete() | ||
|
|
||
|
|
||
| @pytest.fixture(scope="class") | ||
| @pytest.fixture(scope="module") | ||
| def create_image_id(test_linode_client, sample_linode): | ||
| create_image = test_linode_client.images.create( | ||
| sample_linode.disks[0], | ||
| label="linode-api4python-test-image-sharing-image", | ||
| ) | ||
| wait_for_image_status(test_linode_client, create_image.id, "available") | ||
|
|
||
| yield create_image.id | ||
| create_image.delete() | ||
|
|
||
| try: | ||
| create_image.delete() | ||
| except ApiError as e: | ||
| # The image may already have been removed so we ignore [404] Not found | ||
| if e.status != 404: | ||
| raise | ||
|
Comment on lines
+64
to
+69
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a blocking comment, but is there any test case accidentally deleting a image handed to them? |
||
|
|
||
|
|
||
| @pytest.fixture(scope="function") | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.