chore: Node.js release key sync - #2606
Conversation
|
@aduh95 there was an error when I triggered it around tagging the releasers
|
|
I've added the releasers team as triagers on this repo to unblock review requests and codeowners |
MikeMcC399
left a comment
There was a problem hiding this comment.
LGTM and we now have releasers cross-checking, which is even better 👍🏻
| 108F52B48DB57BB0CC439B2997B01419BD92F80A | ||
| A363A499291CBBC940DD62E41F10027AF002F8B0 | ||
| 655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD | ||
| A363A499291CBBC940DD62E41F10027AF002F8B0 |
There was a problem hiding this comment.
Only the order changed?
Correct!
The script update-keys.sh copies the keys in the same order that they are listed in the node > README, where they are sorted in alphabetical order by first name of the signer using the key.
The new key 655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD for @sxa was manually added at the end of the list, instead of using the original order. This caused the mismatch between manual update and automatic update.
See also issue #2569
Open based on changes from
update-keys.sh. For details on whose key is changing, look at https://github.com/nodejs/node#release-keys