Skip to content

chore: Node.js release key sync - #2606

Merged
PeterDaveHello merged 1 commit into
mainfrom
keys-branch
Aug 13, 2026
Merged

chore: Node.js release key sync#2606
PeterDaveHello merged 1 commit into
mainfrom
keys-branch

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Open based on changes from update-keys.sh. For details on whose key is changing, look at https://github.com/nodejs/node#release-keys

@nschonni

Copy link
Copy Markdown
Member

@aduh95 there was an error when I triggered it around tagging the releasers

Error: Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the nodejs/docker-node repository. - https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

@aduh95
aduh95 requested a review from a team August 13, 2026 09:01
@aduh95

aduh95 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

I've added the releasers team as triagers on this repo to unblock review requests and codeowners

@MikeMcC399 MikeMcC399 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and we now have releasers cross-checking, which is even better 👍🏻

Comment thread keys/node.keys
108F52B48DB57BB0CC439B2997B01419BD92F80A
A363A499291CBBC940DD62E41F10027AF002F8B0
655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD
A363A499291CBBC940DD62E41F10027AF002F8B0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the order changed?

@MikeMcC399 MikeMcC399 Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the order changed?

Correct!

The script update-keys.sh copies the keys in the same order that they are listed in the node > README, where they are sorted in alphabetical order by first name of the signer using the key.

The new key 655F3B5C1FB3FA8D1A0CA6BDE4A7D232B936D2FD for @sxa was manually added at the end of the list, instead of using the original order. This caused the mismatch between manual update and automatic update.

See also issue #2569

@MikeMcC399 MikeMcC399 added the keys Related to keys used to sign releases label Aug 13, 2026
@PeterDaveHello
PeterDaveHello merged commit b8bb0a1 into main Aug 13, 2026
2 checks passed
@PeterDaveHello
PeterDaveHello deleted the keys-branch branch August 13, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keys Related to keys used to sign releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants