doc: update installer logo assets to the new branding - #65253
Open
zeexzeex wants to merge 1 commit into
Open
Conversation
Regenerate the Windows MSI banner/dialog bitmaps and the macOS installer background from the standardized logo artwork, keeping the original dimensions and layout. Add a script documenting how the assets are generated, since the original process was lost. The macOS installer previously declared no dark mode background, so no logo was shown at all in dark mode. Add a dark variant of the background and reference it via background-darkAqua. Fixes: nodejs#60213 Refs: openjs-foundation/artwork#24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the installer logo assets in
doc/to the standardizedNode.js branding (openjs-foundation/artwork#24), and adds
tools/generate-installer-assets.shso the assets can be regeneratedreproducibly β as noted in the issue, the original generation process
was lost.
Fixes: #60213
What changed
doc/thin-white-stripe.jpgWixUIBannerBmp)doc/full-white-stripe.jpgWixUIDialogBmp)doc/osx_installer_logo.pngdoc/osx_installer_logo_dark.pngtools/generate-installer-assets.shThe previous attempt (#60218) was closed because replacing the images
without matching the original dimensions would break the fixed-size
installer UI slots. To avoid that, the logo widths and offsets used by
the script were measured from the previous assets, so the layout is
pixel-identical β only the logo artwork and the brand green change.
Dark mode support
The macOS installer declares only a light
<background>, so in darkmode no background was shown at all (dark mode postdates these
assets). This PR adds a dark variant generated from the official
nodejs-logo-stacked-color-dark_background.svgand references it via<background-darkAqua>indistribution.xml.tmpl.How the assets are generated
tools/generate-installer-assets.sh:repository, pinned to a commit SHA for reproducibility;
rsvg-convertand composites with ImageMagickonto each canvas (white for the MSI bitmaps, transparent for macOS);
re-running the script produces byte-identical files.
The top stripe color was updated from the old brand green (
#43853D)to the current one (
#5FA04E), matching the solid fill of thestandardized logo and https://nodejs.org/en/about/branding.
Verification
(
make DISTTYPE=custom CUSTOMTAG=test pkg) as suggested in chore: update logo assetΒ #60218:the background renders correctly in both light and dark mode with
no truncation or stretching β screenshots below.
pkgutil --expandconfirms the packaged background PNG isbyte-identical to the new asset.
already consumes (JPEG, same dimensions, sRGB, 8-bit; baseline
instead of progressive, which is the more conservative variant for
GDI+), so no format compatibility change is expected on Windows.
check of the MSI dialogs during review β the bitmaps keep the exact
dimensions WixUI expects, so no layout change is anticipated.