[release-4.19] OCPBUGS-104577: Backport node_e2e test migrations by Chandan9112 · Pull Request #31484 · openshift/origin

Chandan9112 · 2026-08-05T05:55:10Z

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.19.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅), release-4.21 via PR #31426 (merged ✅), and release-4.20 via PR #31430 (merged ✅). This PR performs the same backport to release-4.19.

Jira

OCPBUGS-104577

Related PRs

Release	PR	Status
4.22	#31306	Merged ✅
4.21	#31426	Merged ✅
4.20	#31430	Merged ✅

Changes (18 files)

New test files (`test/extended/node/node_e2e/`)

File	Test	Feature
`container_runtime_config.go`	ContainerRuntimeConfig pidsLimit/overlaySize	CRC CRD (GA)
`image_mirror_set.go`	ImageDigestMirrorSet / ImageTagMirrorSet	IDMS/ITMS (GA)
`image_registry_config.go`	Image registry allowedRegistries config	image.config (GA)
`initcontainer.go`	Init container restart behavior	Core k8s
`netns_cleanup.go`	Network namespace cleanup	kubelet/CRI-O
`node.go`	Kubelet log level, cgroupv2, devfuse	Core node
`pdb_drain.go`	PDB 100% minAvailable blocks drain	PDB (GA)
`probe_termination.go`	Probe terminationGracePeriodSeconds	Core k8s

Helper files added

node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)
node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)
imagepolicy/imagepolicy_helpers.go — MCP config helper functions (GetMCPCurrentSpecConfigName, WaitForMCPConfigSpecChangeAndUpdated)

Modified files

include.go — Added node/node_e2e blank import for test registration
go.mod — Moved k8s.io/kubelet from indirect to direct dependency
README.md — Documentation for running node tests
bindata.go — Regenerated to include new testdata
zz_generated.annotations.go — Regenerated test annotations

Testdata

testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

4.19-Specific Adaptations

Since release-4.19 has a different dependency baseline compared to 4.20+, the following adaptations were made:

Created imagepolicy/imagepolicy_helpers.go: The test/extended/imagepolicy/ directory does not exist in 4.19. A minimal helper file was created with just GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated functions (used by container_runtime_config.go, image_mirror_set.go, and image_registry_config.go).
Removed ote.Informing() decorators: The openshift-tests-extension package is not available in 4.19's dependency tree. The ote.Informing() test decorator was removed from 4 files (image_mirror_set.go, netns_cleanup.go, pdb_drain.go, probe_termination.go). The tests function identically without this decorator.
Moved k8s.io/kubelet to direct dependency: node_utils.go directly imports kubelet config types.

Feature Verification

All backported tests target features available in OCP 4.19:

ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA
Node cgroupv2, devfuse, kubelet logging are core node features
All tests use [Suite:openshift/disruptive-longrunning] or standard [sig-node] suite tags
No TechPreview or FeatureGate-dependent tests are included

Testing

To validate, trigger the disruptive-longrunning payload job:

/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning

openshift-ci · 2026-08-05T05:55:15Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-08-05T05:55:19Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 946ac325-81a0-4bfe-9cd7-04957b0e1ac4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-05T05:55:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chandan9112
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-08-05T05:57:36Z

@Chandan9112: This pull request references Jira Issue OCPBUGS-104577, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-99782 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-99782 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.19.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅), release-4.21 via PR #31426 (merged ✅), and release-4.20 via PR #31430 (merged ✅). This PR performs the same backport to release-4.19.

Related PRs

Release PR Status

4.22 #31306 Merged ✅

4.21 #31426 Merged ✅

4.20 #31430 Merged ✅

Changes (18 files)

New test files (test/extended/node/node_e2e/)

File Test Feature

container_runtime_config.go ContainerRuntimeConfig pidsLimit/overlaySize CRC CRD (GA)

image_mirror_set.go ImageDigestMirrorSet / ImageTagMirrorSet IDMS/ITMS (GA)

image_registry_config.go Image registry allowedRegistries config image.config (GA)

initcontainer.go Init container restart behavior Core k8s

netns_cleanup.go Network namespace cleanup kubelet/CRI-O

node.go Kubelet log level, cgroupv2, devfuse Core node

pdb_drain.go PDB 100% minAvailable blocks drain PDB (GA)

probe_termination.go Probe terminationGracePeriodSeconds Core k8s

Helper files added

node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)

node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)

imagepolicy/imagepolicy_helpers.go — MCP config helper functions (GetMCPCurrentSpecConfigName, WaitForMCPConfigSpecChangeAndUpdated)

Modified files

include.go — Added node/node_e2e blank import for test registration

go.mod — Moved k8s.io/kubelet from indirect to direct dependency

README.md — Documentation for running node tests

bindata.go — Regenerated to include new testdata

zz_generated.annotations.go — Regenerated test annotations

Testdata

testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

4.19-Specific Adaptations

Since release-4.19 has a different dependency baseline compared to 4.20+, the following adaptations were made:

Created imagepolicy/imagepolicy_helpers.go: The test/extended/imagepolicy/ directory does not exist in 4.19. A minimal helper file was created with just GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated functions (used by container_runtime_config.go, image_mirror_set.go, and image_registry_config.go).

Removed ote.Informing() decorators: The openshift-tests-extension package is not available in 4.19's dependency tree. The ote.Informing() test decorator was removed from 4 files (image_mirror_set.go, netns_cleanup.go, pdb_drain.go, probe_termination.go). The tests function identically without this decorator.

Moved k8s.io/kubelet to direct dependency: node_utils.go directly imports kubelet config types.

Feature Verification

All backported tests target features available in OCP 4.19:

ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA

Node cgroupv2, devfuse, kubelet logging are core node features

All tests use [Suite:openshift/disruptive-longrunning] or standard [sig-node] suite tags

No TechPreview or FeatureGate-dependent tests are included

Testing

To validate, trigger the disruptive-longrunning payload job:
/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning
Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-08-05T05:58:07Z

@Chandan9112: This pull request references Jira Issue OCPBUGS-104577, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-99782 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-99782 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

Details

In response to this:

Summary

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.19.

These tests were previously backported to release-4.22 via PR #31306 (merged ✅), release-4.21 via PR #31426 (merged ✅), and release-4.20 via PR #31430 (merged ✅). This PR performs the same backport to release-4.19.

Jira

OCPBUGS-104577

Related PRs

Release PR Status

4.22 #31306 Merged ✅

4.21 #31426 Merged ✅

4.20 #31430 Merged ✅

Changes (18 files)

New test files (test/extended/node/node_e2e/)

File Test Feature

container_runtime_config.go ContainerRuntimeConfig pidsLimit/overlaySize CRC CRD (GA)

image_mirror_set.go ImageDigestMirrorSet / ImageTagMirrorSet IDMS/ITMS (GA)

image_registry_config.go Image registry allowedRegistries config image.config (GA)

initcontainer.go Init container restart behavior Core k8s

netns_cleanup.go Network namespace cleanup kubelet/CRI-O

node.go Kubelet log level, cgroupv2, devfuse Core node

pdb_drain.go PDB 100% minAvailable blocks drain PDB (GA)

probe_termination.go Probe terminationGracePeriodSeconds Core k8s

Helper files added

node_utils.go — Helper functions (ExecOnNodeWithChroot, WaitForMCP, etc.)

node_mcp_helpers.go — Custom MCP creation/cleanup (NodeHasCustomRole)

imagepolicy/imagepolicy_helpers.go — MCP config helper functions (GetMCPCurrentSpecConfigName, WaitForMCPConfigSpecChangeAndUpdated)

Modified files

include.go — Added node/node_e2e blank import for test registration

go.mod — Moved k8s.io/kubelet from indirect to direct dependency

README.md — Documentation for running node tests

bindata.go — Regenerated to include new testdata

zz_generated.annotations.go — Regenerated test annotations

Testdata

testdata/node/node_e2e/pod-dev-fuse.yaml — Test fixture for devfuse test

4.19-Specific Adaptations

Since release-4.19 has a different dependency baseline compared to 4.20+, the following adaptations were made:

Created imagepolicy/imagepolicy_helpers.go: The test/extended/imagepolicy/ directory does not exist in 4.19. A minimal helper file was created with just GetMCPCurrentSpecConfigName and WaitForMCPConfigSpecChangeAndUpdated functions (used by container_runtime_config.go, image_mirror_set.go, and image_registry_config.go).

Removed ote.Informing() decorators: The openshift-tests-extension package is not available in 4.19's dependency tree. The ote.Informing() test decorator was removed from 4 files (image_mirror_set.go, netns_cleanup.go, pdb_drain.go, probe_termination.go). The tests function identically without this decorator.

Moved k8s.io/kubelet to direct dependency: node_utils.go directly imports kubelet config types.

Feature Verification

All backported tests target features available in OCP 4.19:

ContainerRuntimeConfig, IDMS/ITMS, image registry config, PDBs, probes are GA

Node cgroupv2, devfuse, kubelet logging are core node features

All tests use [Suite:openshift/disruptive-longrunning] or standard [sig-node] suite tags

No TechPreview or FeatureGate-dependent tests are included

Testing

To validate, trigger the disruptive-longrunning payload job:
/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Chandan9112 · 2026-08-11T09:55:47Z

/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning
/payload-job periodic-ci-openshift-release-main-ci-4.19-e2e-gcp-ovn-techpreview

openshift-ci · 2026-08-11T09:55:58Z

@Chandan9112: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning
periodic-ci-openshift-release-main-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d3f7cb20-956a-11f1-9d20-5b7f8aa3d03e-0

Chandan9112 · 2026-08-11T11:42:23Z

/retest

Chandan9112 · 2026-08-12T09:00:03Z

/retest

Bulk backport of node_e2e test case migrations from main (OCP 5.0) to release-4.19. These tests were previously backported to release-4.22 (PR openshift#31306, merged), release-4.21 (PR openshift#31426, merged), and release-4.20 (PR openshift#31430, merged). Key adaptations for 4.19: - Created minimal imagepolicy_helpers.go with MCP helper functions since test/extended/imagepolicy/ directory does not exist in 4.19 - Removed ote.Informing() decorators since openshift-tests-extension package is not available in 4.19 - Moved k8s.io/kubelet from indirect to direct dependency Co-authored-by: Cursor <cursoragent@cursor.com>

openshift-ci · 2026-08-12T15:20:45Z

@Chandan9112: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-edge-zones	`c3d592d`	link	true	`/test e2e-aws-ovn-edge-zones`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Chandan9112 · 2026-08-13T04:16:01Z

/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning

openshift-ci · 2026-08-13T04:16:05Z

@Chandan9112: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b2006b30-96cd-11f1-9f54-63e4f4585316-0

Chandan9112 · 2026-08-13T04:17:20Z

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning-techpreview

openshift-ci · 2026-08-13T04:17:24Z

@Chandan9112: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning-techpreview-1of2
periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e12582b0-96cd-11f1-9614-43ad23381ce3-0

Chandan9112 · 2026-08-13T04:17:31Z

/test e2e-aws-ovn-edge-zones

Chandan9112 · 2026-08-13T06:24:40Z

/payload-job periodic-ci-openshift-release-main-nightly-4.19-e2e-aws-disruptive-longrunning-techpreview

openshift-ci · 2026-08-13T06:24:44Z

@Chandan9112: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

Chandan9112 · 2026-08-13T09:47:14Z

/payload-job periodic-ci-openshift-release-main-ci-4.19-e2e-gcp-ovn-techpreview

openshift-ci · 2026-08-13T09:47:17Z

@Chandan9112: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f772a740-96fb-11f1-85fe-680467779a1a-0

openshift-ci Bot added ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 5, 2026

Chandan9112 changed the title ~~[release-4.19] Backport node_e2e test migrations~~ [release-4.19] OCPBUGS-104577: Backport node_e2e test migrations Aug 5, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 5, 2026

Chandan9112 force-pushed the backport-node-e2e-4.19 branch from 00e5958 to 5f1f6d1 Compare August 11, 2026 07:03

Chandan9112 marked this pull request as ready for review August 11, 2026 07:04

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2026

openshift-ci Bot requested review from LalatenduMohanty and p0lyn0mial August 11, 2026 07:06

Chandan9112 force-pushed the backport-node-e2e-4.19 branch 3 times, most recently from 9f24026 to 91d445d Compare August 12, 2026 07:29

Chandan9112 force-pushed the backport-node-e2e-4.19 branch from 91d445d to 8d7d271 Compare August 12, 2026 11:11

Chandan9112 force-pushed the backport-node-e2e-4.19 branch from 8d7d271 to c3d592d Compare August 12, 2026 11:15

Uh oh!

Conversation

Chandan9112 commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Jira

Related PRs

Changes (18 files)

New test files (test/extended/node/node_e2e/)

Helper files added

Modified files

Testdata

4.19-Specific Adaptations

Feature Verification

Testing

Uh oh!

openshift-ci Bot commented Aug 5, 2026

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Aug 5, 2026

Uh oh!

openshift-ci-robot commented Aug 5, 2026

Summary

Related PRs

Changes (18 files)

New test files (test/extended/node/node_e2e/)

Helper files added

Modified files

Testdata

4.19-Specific Adaptations

Feature Verification

Testing

Uh oh!

openshift-ci-robot commented Aug 5, 2026

Summary

Jira

Related PRs

Changes (18 files)

New test files (test/extended/node/node_e2e/)

Helper files added

Modified files

Testdata

4.19-Specific Adaptations

Feature Verification

Testing

Uh oh!

Chandan9112 commented Aug 11, 2026

Uh oh!

openshift-ci Bot commented Aug 11, 2026

Uh oh!

Chandan9112 commented Aug 11, 2026

Uh oh!

Chandan9112 commented Aug 12, 2026

Uh oh!

openshift-ci Bot commented Aug 12, 2026

Uh oh!

Chandan9112 commented Aug 13, 2026

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Chandan9112 commented Aug 13, 2026

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Chandan9112 commented Aug 13, 2026

Uh oh!

Chandan9112 commented Aug 13, 2026

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Chandan9112 commented Aug 13, 2026

Uh oh!

openshift-ci Bot commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Chandan9112 commented Aug 5, 2026 •

edited

Loading

New test files (`test/extended/node/node_e2e/`)

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

New test files (`test/extended/node/node_e2e/`)

New test files (`test/extended/node/node_e2e/`)