Skip to content

[XWI-128-2] Allow parent and wiki selection - #24705

Open
shiroginne wants to merge 3 commits into
devfrom
feature/xwi-128-select-wiki-to-create-main-pages-when-creating-new-pages-allow-parent-selection
Open

[XWI-128-2] Allow parent and wiki selection #24705
shiroginne wants to merge 3 commits into
devfrom
feature/xwi-128-select-wiki-to-create-main-pages-when-creating-new-pages-allow-parent-selection

Conversation

@shiroginne

@shiroginne shiroginne commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Ticket

XWI-128

What are you trying to accomplish?

This is the second part of the issue.

This ticket implements:

  • allows selecting not only pages, but also by their parents

Screenshots

Screenshot 2026-08-11 at 16 41 07 Screenshot 2026-08-11 at 16 41 24 Screenshot 2026-08-11 at 16 41 50 Screenshot 2026-08-11 at 16 42 07

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@shiroginne shiroginne self-assigned this Aug 11, 2026
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24705, linked for reference only):

- `rspec ./spec/features/activities/work_package/activities_spec.rb[1:5:2:1]`

Treat this as a standalone task, unrelated to PR #24705. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24705 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @shiroginne to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @shiroginne, and request a review from @shiroginne.
On every commit, set @shiroginne as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@shiroginne
shiroginne force-pushed the feature/xwi-128-select-wiki-to-create-main-pages-when-creating-new-pages branch from 32c29f7 to df59aca Compare August 11, 2026 14:12
@shiroginne
shiroginne force-pushed the feature/xwi-128-select-wiki-to-create-main-pages-when-creating-new-pages-allow-parent-selection branch 2 times, most recently from e6730ce to fdaa163 Compare August 11, 2026 14:28
@shiroginne shiroginne changed the title Allow parent and wiki selection [XWI-128] Allow parent and wiki selection Aug 11, 2026
@shiroginne shiroginne changed the title [XWI-128] Allow parent and wiki selection [XWI-128-2] Allow parent and wiki selection Aug 11, 2026
@shiroginne
shiroginne requested a review from a team August 11, 2026 14:57
@shiroginne
shiroginne marked this pull request as ready for review August 11, 2026 14:57
@github-actions

Copy link
Copy Markdown

Caution

The Enterprise plan field is not set on the work package

Details:

Please make sure that:

  • The work package Enterprise plan field is set

Base automatically changed from feature/xwi-128-select-wiki-to-create-main-pages-when-creating-new-pages to dev August 12, 2026 14:41
@shiroginne
shiroginne force-pushed the feature/xwi-128-select-wiki-to-create-main-pages-when-creating-new-pages-allow-parent-selection branch from 9be1083 to 2135ed8 Compare August 12, 2026 14:41
…ges-when-creating-new-pages-allow-parent-selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant