feat(text-input)!: port to <pf-v6-text-input> - #3160
Draft
zeroedin wants to merge 6 commits into
Draft
Conversation
🦋 Changeset detectedLatest commit: af1aabd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(text-input)!: port to `<pf-v6-text-input>`"
} |
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
<pf-v5-text-input><pf-v5-text-input>to<pf-v6-text-input>web component for PatternFly v6typevariants, validation states, and custom icon supportElementInternals, supports form reset, constraint validation (checkValidity(),reportValidity(),setCustomValidity())referenceTarget: when available, external<label for>andaria-describedbyresolve natively through the shadow boundarydelegatesFocus+computedLabelTextstring copy (same mechanism as v5)role="alert"+aria-describedbyon the internal input--pf-v6-c-form-control--*,--pf-t--global--*) withlight-dark()fallbacks::before/::afterpseudo-elements for border styling (matching v6 SCSS structure)classMapinstead of:host([attr])selectorschangeevent: callpreventDefault()to reject a value change<label for="id">oraccessible-labelattributeInternalsController fix (pfe-core)
form,validationMessage, andwillValidategetters onInternalsControllerdeclare-only (TypeScript type annotations with no runtime implementation) since the dynamic proxy was removed in feat: listbox elements #2570pf-v6-text-inputfor Enter-to-submit (form?.requestSubmit()) and error message rendering (validationMessage)Closes #3043
Intentional divergences from React
customIconprop replaced byiconslot (slotted content for composability)isDisabled/isRequiredrenamed todisabled/required(nois-prefix per web component convention)isStartTruncatedreplaced bytruncated="start"enum attribute for future extensibilityreadOnlyVariantsplit intoreadonly+plainattributes (native HTMLreadonly+ visual modifier)isExpanded/expandedPropsnot implemented (combobox patterns will be handled by a dedicated composite element)onChangecallback replaced by cancelablechangeDOM eventvalidated="default"state represented by attribute absenceinnerRef+.select()replaced byselect()method directly on the elementTesting Instructions
Notes to Reviewers